Repository navigation
test(agent): make attachment sweep lease fixtures explicit - #1298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stale-draft sweep test failed during 0.0.8 preparation at its final deletion assertion. Its fixture closed one
Filehandle and assumed the lease was gone, although duplicated or inherited descriptors can retain that OS lock.Explicitly unlock the fixture's lease before checking abandoned-copy cleanup, and derive the synthetic age from the directory's recorded modification time. Add a Unix regression proving that a duplicated descriptor still protects the payload after the original handle closes, and that cleanup succeeds after explicit unlock. Production staging, cleanup and lock checks are unchanged.
Validation:
just cipassed: all four strict Clippy configurations, warning-denied build/tests, 759 runtime tests, 1,010 desktop tests, 307 headless tests and 65 updater tests.f4762293: 21 successful checks and 18 intentional skips.The original failure log did not record which sweep guard or removal step prevented deletion, so this does not attribute that particular run to a fork or establish a production cleanup defect. Agent 0.0.8 remains on hold for review; this PR changes no app versions or runtime behavior.
Need help on this PR? Tag
@codesmith-botwith what you need.