fix(helm): align values with ts-server-boilerplate server/telemetry split - #116
Open
CL-SHLOMIKONCHA wants to merge 17 commits into
Open
CL-SHLOMIKONCHA wants to merge 17 commits into
CL-SHLOMIKONCHA wants to merge 17 commits into
Conversation
The raster-core umbrella chart overrides this value on every deployment. Make it the chart default so the override can be removed.
Align the chart with ts-server-boilerplate: - replace the flat env block with a server scope (port, targetPort, protocol, requestPayloadLimit, responseCompressionEnabled) and a telemetry scope (logger, tracing) - rename logger keys to level and prettyPrint to match the config schema - export the otlp logger url as OTLP_LOGGER_ENDPOINT_URL and resource attributes as OTEL_RESOURCE_ATTRIBUTES in key=value,key=value format, the names the commonBoilerplateV3 schema and the OpenTelemetry SDK read - move global overrides under global.telemetry; only the tracing and otlp logger urls are overridable from global and take precedence over chart values, enabled flags stay chart-level - drop the tracingEnabled and common.openTelemetryOptions.merged helpers - reference $server / $telemetry via with blocks across the templates Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
CL-SHLOMIKONCHA
changed the title
Match the env var name the helm configmap now exports and the commonBoilerplateV3 schema reads. Drop the JSON resourceAttributes mapping: the chart exports OTEL_RESOURCE_ATTRIBUTES, which the OpenTelemetry SDK picks up on its own. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The commonBoilerplateV3 schema already resolves enabled and url from OPENTELEMETRY_LOGGING_ENABLED and OTLP_LOGGER_ENDPOINT_URL via x-env-value, at a higher priority than the node-config mapping. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Keep the opentelemetryOptions mapping in custom-environment-variables.json pointing at OPENTELEMETRY_LOGGING_ENABLED and OTLP_LOGGER_ENDPOINT_URL, matching the commonBoilerplateV3 schema, and describe next to the opentelemetryOptions scope in values.yaml which env vars it renders and who consumes them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ies/raster-catalog-manager into fix/helm-default-values
Put the opentelemetryOptions mapping back in custom-environment-variables.json, pointing at OPENTELEMETRY_LOGGING_ENABLED and OTLP_LOGGER_ENDPOINT_URL to match the commonBoilerplateV3 schema. Describe next to the opentelemetryOptions scope in values.yaml which env vars it renders and who consumes them. Restore the empty typeOrm placeholders in default.json. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Map telemetry.logger.opentelemetryOptions.resourceAttributes from OPENTELEMETRY_RESOURCE_ATTRIBUTES (JSON) again and have the configmap export it alongside OTEL_RESOURCE_ATTRIBUTES, so the attributes reach both the config object and the OpenTelemetry SDK. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Emit OPENTELEMETRY_LOGGING_ENABLED and TELEMETRY_TRACING_ENABLED with their actual value instead of only when enabled, as the chart did before the server/telemetry split, so a disabled feature is explicit in the configmap. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Use the single OTEL_RESOURCE_ATTRIBUTES variable the configmap exports for the config mapping as well, and drop the JSON OPENTELEMETRY_RESOURCE_ATTRIBUTES export. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
vitaligi
requested changes
Sep 14, 2026
This was referenced Sep 14, 2026
fix(helm): align values with ts-server-boilerplate server/telemetry split
MapColonies/job-tracker#76
Open
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint, so spreading it is enough. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
DB_HOST and DB_NAME default to empty strings and rendered as null, which Kubernetes rejects in ConfigMap data. Quote every remaining unquoted entry so all values are always emitted as strings.
vitaligi
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: raster-core umbrella chart TODOs (
helm-charts-new→charts/raster-core/values.yaml), MapColonies/ts-server-boilerplate#476 (MAPCO-11622)Further information:
Default values
configManagement.offlineModedefaults totrue(wasfalse), resolving the# TODO: remove after set this as the default value within serviceoverride in the raster-core umbrella chart.logLeveldefaults toinfo,requestPayloadLimitto5mb, tracing and OpenTelemetry logging enabled by default.Server / telemetry split (mirrors ts-server-boilerplate#476)
envblock is replaced by aserverscope (port,targetPort,protocol,requestPayloadLimit,responseCompressionEnabled) and atelemetryscope (logger,tracing).level/prettyPrint;logger.opentelemetryOptionsholdsenabled,urland optionalresourceAttributes.OTLP_LOGGER_ENDPOINT_URL, the name thecommonBoilerplateV3schema reads; the previousOPENTELEMETRY_LOGGING_URLkey was not consumed. Resource attributes are exported asOTEL_RESOURCE_ATTRIBUTES(key=value,key=value), read by the OpenTelemetry SDK and mapped as a string in the config.global.telemetrywith the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.tracingEnabledandcommon.openTelemetryOptions.mergedhelpers removed.config/custom-environment-variables.jsonmapstelemetry.logger.opentelemetryOptionsfromOPENTELEMETRY_LOGGING_ENABLED,OTLP_LOGGER_ENDPOINT_URLandOTEL_RESOURCE_ATTRIBUTES.Breaking for consumers: umbrella charts setting
env.*,global.tracing.*orglobal.openTelemetryOptions.*must move toserver.*,telemetry.*andglobal.telemetry.*.🤖 Generated with Claude Code