fix(helm): align chart defaults with raster-core values and split server/telemetry scopes - #110
Open
CL-SHLOMIKONCHA wants to merge 8 commits into
Open
CL-SHLOMIKONCHA wants to merge 8 commits into
CL-SHLOMIKONCHA wants to merge 8 commits into
Conversation
- imagePullPolicy: IfNotPresent (was Always) - metrics enabled by default with prometheus scrape and localhost metrics url - entities.polygonParts.minAreaSquareDeg: 1e-12 (was 1e-15) - validation.areaThresholdSquareMeters: 10 (was 5) These values are currently overridden by the raster-core umbrella chart; making them defaults lets the overrides be removed.
Align the chart with ts-server-boilerplate: - replace the flat env block with a server scope (port, targetPort, protocol, requestPayloadLimit, responseCompressionEnabled) and a telemetry scope (logger, tracing, metrics) - move the application block from env.application to a top-level application scope - rename logger keys to level and prettyPrint to match the config schema - export the otlp logger url as OTLP_LOGGER_ENDPOINT_URL and resource attributes as OTEL_RESOURCE_ATTRIBUTES in key=value,key=value format, the names the commonBoilerplateV3 schema and the OpenTelemetry SDK read - move global overrides under global.telemetry; only the tracing, metrics and otlp logger urls are overridable from global and take precedence over chart values, enabled flags stay chart-level - drop the common.tracing/metrics/openTelemetryOptions.merged helpers - default requestPayloadLimit to 10mb as deployed by site-values Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Read opentelemetryOptions.url from OTLP_LOGGER_ENDPOINT_URL and resourceAttributes from OTEL_RESOURCE_ATTRIBUTES, matching the helm configmap and the commonBoilerplateV3 schema. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
CL-SHLOMIKONCHA
changed the title
Nothing in the service reads telemetry.metrics and the schema declares no env var for it, so TELEMETRY_METRICS_* were never consumed. Pod prometheus annotations come from mclabels, which made the chart's own annotations duplicates. Drop the metrics scope, the global override, the metricsUrl helper and the configmap keys. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Only server and telemetry leave env; the application keys stay where consumers already set them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
vitaligi
requested changes
Sep 14, 2026
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint, so spreading it is enough. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Nothing reads telemetry.metrics: the boilerplate schema declares it without properties or env bindings, the app builds its prom-client registry without config, and the helm chart stopped emitting TELEMETRY_METRICS_* in 310dcc5. Pod scrape annotations come from mclabels and do not depend on these vars.
vitaligi
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: raster-core umbrella chart TODOs (
helm-charts-new→charts/raster-core/values.yaml), site-valuesraster/core/base.yaml.gotmpl, MapColonies/ts-server-boilerplate#476 (MAPCO-11622)Further information:
Default values (resolve the raster-core
# TODOoverrides)imagePullPolicyAlwaysIfNotPresentconfigManagement.offlineModetruetrue(already default)env.application.entities.polygonParts.minAreaSquareDeg1e-151e-12env.application.validation.areaThresholdSquareMeters510server.requestPayloadLimit1mb10mb(as set by site-values)Note:
config/default.jsonstill carries1e-15/5for local runs; only the Helm defaults were changed, since the deployed values come from the chart's configmap.Server / telemetry split (mirrors ts-server-boilerplate#476)
envblock is replaced by aserverscope (port,targetPort,protocol,requestPayloadLimit,responseCompressionEnabled) and atelemetryscope (logger,tracing).env.application.*stays underenv, unchanged; only the server and telemetry keys leave theenvscope.level/prettyPrint;logger.opentelemetryOptionsholdsenabled,urland optionalresourceAttributes.OTLP_LOGGER_ENDPOINT_URLand resource attributes asOTEL_RESOURCE_ATTRIBUTES(key=value,key=value), the names thecommonBoilerplateV3schema and the OpenTelemetry SDK read.config/custom-environment-variables.jsonmaps them accordingly.OPENTELEMETRY_LOGGING_ENABLEDandTELEMETRY_TRACING_ENABLEDare always exported with their value; urls only when enabled.global.telemetrywith the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.common.tracing.merged,common.metrics.mergedandcommon.openTelemetryOptions.mergedhelpers removed.metricsvalues are removed entirely, as in the boilerplate: nothing in the service readstelemetry.metrics,TELEMETRY_METRICS_*were never consumed, and the pod Prometheus annotations come from mclabels (the chart's own annotations were duplicates). Raster-core'spolygon-parts-manager.metricsblock can simply be dropped.Breaking for consumers: umbrella charts and site-values setting
env.*,tracing.*,metrics.*,global.tracing.*,global.metrics.*orglobal.openTelemetryOptions.*must move toserver.*,telemetry.*andglobal.telemetry.*;env.application.*keeps its path. Known spots: raster-corepolygon-parts-manager.metrics(drop, no longer exists) andpolygon-parts-manager.env.application.*(can be dropped, now defaults), site-valuespolygon-parts-manager.env.requestPayloadLimit(can be dropped, now default).🤖 Generated with Claude Code