Repository navigation
Vendors: Use MafiaNet 0.23.0 header names - #161
Conversation
MafiaNet 0.23.0 renames every header to snake_case (BitStream.h -> bit_stream.h). The Framework now pins it, so each MafiaNet include moves to its new name. Only include lines change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughClient and server source files now use lowercase filenames in MafiaNet bit-stream includes. Client module headers also use a lowercase filename for the ReplicaManager3 include. No runtime logic changes are shown. ChangesHeader Include Paths
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
MafiaNet 0.23.0 renames every header to snake_case (
BitStream.h→bit_stream.h). MafiaHub/Framework#329 pins it, so each MafiaNet include moves to its new name. The rewrite uses MafiaNet's own rename list, and only#includelines change.Merge together with MafiaHub/Framework#329. Neither builds without the other.
Built against #329: the client already fails to build for unrelated reasons (
imgui/imgui.h,fu2/function2.hppandcxxopts.hpparen't found). None of the errors involve MafiaNet.Summary by CodeRabbit