Skip to content

Vendors: Use MafiaNet 0.23.0 header names - #161

Merged
Segfaultd merged 1 commit into
masterfrom
vendors/mafianet-0.23.0
Oct 15, 2026
Merged

Segfaultd merged 1 commit into
masterfrom
vendors/mafianet-0.23.0

Conversation

@Segfaultd

@Segfaultd Segfaultd commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

MafiaNet 0.23.0 renames every header to snake_case (BitStream.h → bit_stream.h). MafiaHub/Framework#329 pins it, so each MafiaNet include moves to its new name. The rewrite uses MafiaNet's own rename list, and only #include lines change.

Merge together with MafiaHub/Framework#329. Neither builds without the other.

Built against #329: the client already fails to build for unrelated reasons (imgui/imgui.h, fu2/function2.hpp and cxxopts.hpp aren't found). None of the errors involve MafiaNet.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected header-name capitalization in the client and server code to match the networking library, improving build compatibility on case-sensitive systems. No runtime behavior changes.

MafiaNet 0.23.0 renames every header to snake_case (BitStream.h ->
bit_stream.h). The Framework now pins it, so each MafiaNet include
moves to its new name. Only include lines change.
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1008e48a-7f40-4fa9-8b54-7346e7f1f762
📥 Commits

Reviewing files that changed from the base of the PR and between 957905b and 569d246.

📒 Files selected for processing: 8
  • code/client/src/core/application.cpp
  • code/client/src/core/dev_features.cpp
  • code/client/src/core/local_player_events.cpp
  • code/client/src/core/modules/human.cpp
  • code/client/src/core/modules/human.h
  • code/client/src/core/modules/vehicle.h
  • code/server/src/core/builtins/human.cpp
  • code/server/src/core/server.cpp

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Client and server source files now use lowercase filenames in MafiaNet bit-stream includes. Client module headers also use a lowercase filename for the ReplicaManager3 include. No runtime logic changes are shown.

Changes

Header Include Paths

Layer / File(s) Summary
Lowercase header include paths
code/client/src/core/application.cpp, code/client/src/core/dev_features.cpp, code/client/src/core/local_player_events.cpp, code/client/src/core/modules/human.cpp, code/client/src/core/modules/human.h, code/client/src/core/modules/vehicle.h, code/server/src/core/builtins/human.cpp, code/server/src/core/server.cpp
MafiaNet bit-stream includes and client ReplicaManager3 includes now use lowercase header filenames.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 569d2

The updated include paths match MafiaNet 0.23.0. Merge this change with the corresponding Framework dependency update.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating vendor MafiaNet includes to the 0.23.0 header names.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 8…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each header name,
Lowercase paths now match the game.
Bit streams hop from side to side,
Replica headers join the ride.
No runtime changes came to be.

Comment @coderabbitai help to get the list of available commands.

@Segfaultd
Segfaultd merged commit be65176 into master Oct 15, 2026
2 checks passed
@Segfaultd
Segfaultd deleted the vendors/mafianet-0.23.0 branch October 15, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants