Repository navigation
Vendors: Pin MafiaNet 0.23.0 - #329
Merged
Merged
Conversation
0.23.0 makes a Shutdown() from inside receive dispatch safe: it no longer frees the packet being dispatched or the FileListTransfer receiver whose callback is running, which is the crash a client hit when it refused a join from its asset download callback (#315). 0.23.0 also renames every header to snake_case, so each MafiaNet include moves to its new name. The wire format is unchanged (RAKNET_PROTOCOL_VERSION 7).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe MafiaNet pin advances from 0.22.1 to 0.23.0, and its archive hashes are updated. Framework and test includes now use the dependency’s lowercase header paths. No runtime logic or test expectations change. ChangesMafiaNet Update
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 38 files. (1 skipped: 1… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely identifies the primary change: pinning the MafiaNet vendor dependency to version 0.23.0. Linked Issues check Issue #315requires removal of the receive-dispatch shutdown use-after-free. The PR pins MafiaNet 0.23.0, whose documented release behavior keeps the active packet and FileListTransfer receiver valid …Out of Scope Changes check The changes are limited to the MafiaNet 0.23.0 pin, its archive hashes, and include-path rewrites required by the pinned release. The include changes affect Framework and FrameworkTests files that con…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 38 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks each header’s name,
Then hops through paths that changed their case.
New hashes sit beside the pin,
While tests keep all their old routines.
The rabbit rests beside the build.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315.
What changes
MAFIANET_PIN_VERSIONgoes to 0.23.0, with the five archive hashes taken from the release assets.Shutdown()called from inside receive dispatch no longer frees the packet being dispatched or theFileListTransferreceiver whose callback is running. That was the crash when a client refused a join fromOnAssetsDownloaded.BitStream.h→bit_stream.h,RakVoice.h→voice.h). The 38 Framework files that include MafiaNet are rewritten from MafiaNet's owngit diff -Mrename list; only#includelines change.RAKNET_PROTOCOL_VERSIONis still 7. Nothing Framework uses moved toMafiaNetExtras.Projects
Every project under
code/projectsthat includes MafiaNet needs the same include rewrite before it builds against this pin. The renames add underscores, not just case, so they break on Windows too. Those are separate repos and land separately.Testing
Framework, FrameworkClient, FrameworkServer and FrameworkTests build on Windows x64. The 0.23.0 archive downloads and its hash verifies. FrameworkTests: 662/662.
Summary by CodeRabbit