Repository navigation
fix: preserve imported builds and native item properties - #1013
Conversation
Retain native item crafting state and secondary progression through strict build admission, wire encoding and relational saves. Match native modifier magnitudes, defence rounding and passive radius geometry.
|
Merged through #1024 with two additional import corrections. Imported tattoos now use the same native target and limit rules as ordinary tattoo application, including the total limit and applicable per-tattoo restrictions. Reimport also discards transient Game.Golems session data from the incoming build, preventing obsolete runtime summon state from being restored. Review covered preservation of progression, secondary ascendancy, native crafting/relic/style properties, catalyst behavior, defense rounding, and passive/jewel data. Regression coverage verifies preservation and rejects invalid tattoo targets. The final build and all 1,006 tests passed, and the disposable database rebuilds succeeded. No outstanding import defect was identified. Recommended follow-up is an end-to-end native import → play → save → reimport check using a representative build with relic/style items, catalyst quality, tattoos/runegrafts and secondary ascendancy. Those combinations were covered primarily through code/data review and automated tests rather than a complete live-client round trip. |
What changes
Valid external character builds could lose item crafting state, secondary ascendancy or native passive overrides, while the server had no game-owned admission check for the complete imported tree. This change preserves native state through protocol, JSON and relational saves and gives the Game module the final say on imported allocations before preview and replacement.
Native items and persistence
Whole-build admission and progress
Item calculations and passive geometry
Layer
Framework: native protocol/item state, persistence, catalogue/graph geometry and a general game-logic admission hook in
src/.Module: real game rules in
Modules/Core/GameandModules/Core/Item/Tattoos; native effect defaults insql/updates/pending_world/. No POB parser, share-code registry or mod settings are added to the framework or shipped leagues.Mod companion: LocalExile/LocalExile-Mods#43 contains the standalone converter source and frontend process cleanup. The server change is the prerequisite for the companion's new native properties and validation. Delve changes are excluded.
Issue
No separate public issue. Repairs failures found while importing native character exports and a supplied edited PoB code.
Checks
main:ffb9c93e857070a95674087d78324e9ae703c6aa.ffcd505c8b3ea5432da76c7a6baed01e8c8476d3.dotnet build GameServer.slnx: zero warnings and zero errors.Verification limits
The large corpus was checked through strict conversion and actual server validation/encoding, not by applying every character and playing its skills. Import/persistence success is not a claim of complete combat parity: some specialized Runegraft/stat consumers still need implementation. Native snapshots/fingerprint indexes used to recover omitted raw rolls are operator-owned and excluded from both PRs.
For the reviewer
sql/: two pending character-schema updates and two pending world-effect updates.src/GameServer.Gateway/Modding/GameLogic.csandsql/updates/pending_characters/. These require the maintainers' review; no approval, merge or check bypass is requested.The existing local client/settings, downloaded build collection, private native indexes, accounts, keys and unrelated Delve work are not in this branch.