Repository navigation
fix(pob): publish strict native build converter - #43
Merged
Merged
Conversation
Include the separate operator-configured converter source, preserve exact native item and passive state, reject incomplete conversions, and reap canceled converter processes.
9 of 12 tasks
Collaborator
Author
|
This PR requires LocalExile/LocalExile#1013 for native item persistence/encoding and game-owned whole-build validation. Please merge the server update first and set compatibleClientVersions to the actual shipping LocalExile release before merging this mod update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The POB frontend could accept an external converter, but the converter fixes used for the local build collection were not available in the mod repository. This PR publishes that converter as a separate, operator-configured source project and updates POB to 1.0.3. Preparation fails on unresolved input rather than silently removing parts of a character.
Strict conversion and exact native provenance
Passives and character progress
Packaging and process ownership
mods/pob/Converter/PobImport.csprojas a standalone .NET 10 console project. The frontend excludes its C# files from its own compilation, and normal frontend releases do not automatically build, install or run the converter.converterExecutableand fixed-argument settings and JSON stdin/stdout contract. Existing/pob, file import, confirmation and cancellation flows remain available.mods.json; retain authornikolos89and the existing default catalog symbol. No binaries, game files, client tables, snapshots, native indexes, accounts, keys, personal settings or Delve changes are included.Layer and dependency
Mod: all feature-specific conversion code stays under
mods/pob/. The converter links the companion server's native table readers and shared catalyst/Heist magnitude calculations at build time usingLocalExileRoot.Required server PR: LocalExile/LocalExile#1013 must merge first. It provides native item persistence/encoding and the general game-owned whole-build validation hand-over.
compatibleClientVersionstemporarily lists the latest release,0.5.1-beta, as required by this repository's dependent-update workflow; this is not a claim that the converter works with that unmodified release. The maintainer must set the actual shipping version before merging.Validation
main:3fea6830404e4bb0e58e3cfe176775c458402031; head:76589f3bc58c4e28f8b54f866c5e1d499524f5b9.tools/build-index.ps1 -Checkpassed; all 11 catalog entries are current.Limits for review
Some PoB text omits information needed for exact native reconstruction; the operator must provide matching native provenance or conversion fails. Import and encoding success do not establish full combat behavior for every rare stat or Runegraft. This PR preserves the data and reports validation failures rather than promising unsupported gameplay parity. The source converter is separate trusted operator software, not an operating-system sandbox.
No release, tag, approval or merge is requested here. Review the server dependency first.