Skip to content

fix(pob): publish strict native build converter - #43

Merged
evrydayjunglist merged 1 commit into
mainfrom
codex/pob-lossless-converter-20261114
Nov 18, 2026
Merged

evrydayjunglist merged 1 commit into
mainfrom
codex/pob-lossless-converter-20261114

Conversation

@nikolos89

Copy link
Copy Markdown
Collaborator

What changes

The POB frontend could accept an external converter, but the converter fixes used for the local build collection were not available in the mod repository. This PR publishes that converter as a separate, operator-configured source project and updates POB to 1.0.3. Preparation fails on unresolved input rather than silently removing parts of a character.

Strict conversion and exact native provenance

  • Decode bounded PoB share codes and validate their compressed stream/checksum before parsing XML. Malformed or truncated input cannot become a partially imported character.
  • Convert items, native modifiers and their ranges, gem socket positions, supports and inactive gems, weapon swaps, influences, quality types, native item properties and level requirements into the server's versioned prepared-build JSON.
  • Preserve Intangibility and Memory Strands as native item properties. Preserve foil/vestigial and transformed-item state instead of generating unsupported-stat warnings for these properties.
  • Recover omitted raw rolls and physical socket information from a matching native snapshot when available. An optional operator-owned share-code index resolves original exports; an optional exact-item fingerprint index supports items retained in edited exports. A changed item with the same UID cannot borrow the previous item's native rolls.
  • Never fill an unknown variable unique roll with its maximum. A fixed native value may be reconstructed; a missing variable value stops preparation with an error. No items, gems, passives or effects are deliberately dropped to make a build pass.

Passives and character progress

  • Convert ordinary and cluster passives, masteries, radius jewels, tattoos, mastery-replacing Runegrafts, main and secondary ascendancy, and exported bandit intent.
  • Retain native override identities and values so the companion Game module can validate their targets, limits and mastery replacement behavior.
  • Keep character/account/name/league identity unchanged. The server still performs independent preview validation and atomic replacement; this converter does not open or write the character save database.

Packaging and process ownership

  • Add mods/pob/Converter/PobImport.csproj as a standalone .NET 10 console project. The frontend excludes its C# files from its own compilation, and normal frontend releases do not automatically build, install or run the converter.
  • Keep the existing converterExecutable and fixed-argument settings and JSON stdin/stdout contract. Existing /pob, file import, confirmation and cancellation flows remain available.
  • Await converter process exit after cancellation/termination so an owned child is reaped before cleanup completes.
  • Document build/setup commands, read-only native data dependencies, optional private provenance indexes and failure behavior. Include upstream source attribution and the converter's existing GPLv2 license separately from the frontend.
  • Update mods.json; retain author nikolos89 and the existing default catalog symbol. No binaries, game files, client tables, snapshots, native indexes, accounts, keys, personal settings or Delve changes are included.

Layer and dependency

Mod: all feature-specific conversion code stays under mods/pob/. The converter links the companion server's native table readers and shared catalyst/Heist magnitude calculations at build time using LocalExileRoot.

Required server PR: LocalExile/LocalExile#1013 must merge first. It provides native item persistence/encoding and the general game-owned whole-build validation hand-over. compatibleClientVersions temporarily lists the latest release, 0.5.1-beta, as required by this repository's dependent-update workflow; this is not a claim that the converter works with that unmodified release. The maintainer must set the actual shipping version before merging.

Validation

  • Base main: 3fea6830404e4bb0e58e3cfe176775c458402031; head: 76589f3bc58c4e28f8b54f866c5e1d499524f5b9.
  • POB frontend and standalone converter: both build with zero warnings and zero errors against the exact companion server tree.
  • Waypoint catalog: tools/build-index.ps1 -Check passed; all 11 catalog entries are current.
  • Published converter positive/negative fixtures and current-main server admission: all three passed: supplied-code conversion matches the prior audited Record/Save/Warnings exactly; corrupt code and altered-same-UID inputs are rejected; the positive output is accepted by the exact companion Gateway/Game rules without applying a character.
  • Prior complete collection audit: 39,826 native snapshots plus the supplied edited share code; 39,827/39,827 strict conversions and actual Gateway/Game validations, with no loss diagnostics. Corrupted checksum and altered-same-UID fixtures are rejected. The public source retains that audited conversion logic; dead export/database-writing helpers are excluded.
  • The existing local Gateway loaded the POB frontend with the existing settings. No production character was replaced during this PR preparation, no extra server/client was started, and no client files were changed. A new gameplay import/unload cycle was not performed against this publication snapshot.

Limits for review

Some PoB text omits information needed for exact native reconstruction; the operator must provide matching native provenance or conversion fails. Import and encoding success do not establish full combat behavior for every rare stat or Runegraft. This PR preserves the data and reports validation failures rather than promising unsupported gameplay parity. The source converter is separate trusted operator software, not an operating-system sandbox.

No release, tag, approval or merge is requested here. Review the server dependency first.

Include the separate operator-configured converter source, preserve exact native item and passive state, reject incomplete conversions, and reap canceled converter processes.
@nikolos89 nikolos89 added the Requires LocalExile Update This mod will only be compatible after a certain LocalExile PR is merged to support this mod. label Nov 14, 2026
@nikolos89

Copy link
Copy Markdown
Collaborator Author

This PR requires LocalExile/LocalExile#1013 for native item persistence/encoding and game-owned whole-build validation. Please merge the server update first and set compatibleClientVersions to the actual shipping LocalExile release before merging this mod update.

@evrydayjunglist
evrydayjunglist merged commit f8a2688 into main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Requires LocalExile Update This mod will only be compatible after a certain LocalExile PR is merged to support this mod.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants