Repository navigation
Conversation
Kavya0224
requested review from
RalfLeonFasler and
ThoreKoritzius
as code owners
November 17, 2026 12:50
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103
#84 stacked the HUD notices in one centred column on tablets and desktops, as
#79 did on phones, but repeated the phone block's column rules. The two media
queries together cover every screen size, so the column belongs outside them.
What changed
.hud-noticesrule now holds the column layout (position,display: flex,flex-direction,align-items,pointer-events), plus theshared
> *,.milestone-banner.showand.hud-statusrules, once each.top,left,right,gap, andthe phone-only
.race-call { white-space: normal; }.display: contentsrule and its outdated comment.hud-statusblock, now part of the shared ruleswhite-space: nowrapon.hud-statusin the phone block, because the base.hud-statusrule already sets it for every screenThe later, more specific rules (landscape
trainingandraceoverrides, thebroadcast and narrow-tablet
left/right, and the:has()one-notice-at-a-timerules) are unchanged and still override the shared rules as before.
No visual change is intended.
Checks
styles.cssrepeats a property that another rule for thesame screens already sets
i18nHtmlandi18nSweepfail on my Windows machine with and without this change(a
C:\C:\...path error), so I'm relying on CI for them.make check: I couldn't run it locally (nomakeor Rust on my machine),so I'm relying on CI.
(phone upright and sideways) and 1440×900 and 900×1440 (desktop and
tablet), in the layouts: .
Screenshots
Before and after look the same at every size, as intended. I can add the
remaining sizes and layouts if you'd like them.