Skip to content

Share the HUD notices column CSS between phones and larger screens #103

Open

Description

@RalfLeonFasler

Problem

#84 stacks the HUD notices in one centred column on tablets and desktops, as #79 did on phones. The new tablet/desktop block in client/public/styles.css repeats the phone block's column rules instead of sharing them:

Rule Phone block (@media (max-width: 760px), (max-height: 500px) and (orientation: landscape)) Tablet/desktop block (@media (min-width: 761px) and (min-height: 501px))
.hud-notices > * { position: static; transform: none; max-width: 100%; margin: 0; } yes yes, same
.hud-notices .milestone-banner.show { animation-name: milestone-in-column; } yes yes, same
.hud-notices .hud-status { flex-wrap: wrap; justify-content: center; } yes (+ white-space: nowrap) at top level, for every screen, which makes the phone's two lines dead

The two media queries together now cover every screen size, so the top-level .hud-notices { display: contents; } never applies, and its comment ("Large screens: the wrapper makes no box, each keeps its own place") is out of date.

Proposal

Notices are now a column on every screen, so the column rules belong outside the media queries:

  • One top-level .hud-notices rule with the column layout (position: absolute, display: flex, flex-direction: column, align-items: center, pointer-events: none), plus the shared > *, .milestone-banner.show and .hud-status rules once.
  • The media queries only set what differs: top, left, right, gap, and phone-only pieces such as .race-call { white-space: normal; } and .hud-status { white-space: nowrap; }.
  • Drop display: contents and its comment.

No visual change is intended.

Acceptance criteria

  • No selector in styles.css repeats a property that another rule for the same screens already sets.
  • Notices look the same as after fix(client): Stack the HUD notices on tablets and desktops too #84 on a phone (portrait and landscape), an upright and a landscape tablet, and a desktop, in all four layouts (screenshots before and after).
  • make check passes.

Split out of the review of #84.

Activity

  1. Kavya0224 commented on Nov 14, 2026

    @Kavya0224

    Hi, I'd like to work on this.

  2. RalfLeonFasler commented on Nov 14, 2026

    @RalfLeonFasler
    ContributorAuthor

    @Kavya0224 happy have you here.
    You can go ahead and do it. Make sure to assign the issue to yourself so its clear that you are working on it

  3. Kavya0224 commented on Nov 15, 2026

    @Kavya0224

    Thanks! But I don't have write permissions on the repo to assign myself.

  4. Kavya0224 commented on Nov 17, 2026

    @Kavya0224

    Opened a PR for this: #122
    Ready for review. The checks are waiting for a maintainer to approve the workflow run, since this PR comes from a fork. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestgood first issueGood for newcomersjavascriptPull requests that update javascript code

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions