Skip to content

Require complete project-root indexes in module-system packages #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vilin97 merged 1 commit into from
Oct 1, 2026
Merged

Require complete project-root indexes in module-system packages #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/lean_pool/indexes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"Released under Apache 2.0 license as described in the file LICENSE.\n"
"Authors: Lean Pool contributors\n-/\n" + MODULE_HEADER + GENERATED_MARKER
)
# Removed after the separate content migration has landed.
REQUIRE_PROJECT_ROOTS = False
# Production module-system packages must never revert to a flat index.
REQUIRE_PROJECT_ROOTS = True


def project_modules(root: Path) -> dict[str, list[str]]:
Expand Down
2 changes: 1 addition & 1 deletion python/tests/test_rebase_fastpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def rebased(tmp_path: Path) -> tuple[Path, str, str, str, str]:
(root / "LeanPool/A.lean").write_text("module\n")
(root / "LeanPool/projects.yml").write_text("projects:\n - slug: a\n")
for name in rebase_fastpath.PINNED_INPUTS:
(root / name).write_text(name)
(root / name).write_text('name = "test"\n' if name == "lakefile.toml" else name)
_index(root)
old_base = _commit(root, "base")

Expand Down
Loading