Repository navigation
Require complete project-root indexes in module-system packages - #560
Merged
Merged
Conversation
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Medium risk] Enforces stricter module indexing rules in the build system. The PR appears safe to merge; no actionable regression was identified. SummaryThis PR makes project-root aggregates mandatory for module-system packages while preserving flat indexes for non-module fixtures.
Reviews (1) · Last reviewed commit: "Require complete project-root indexes in..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #559 migrated every project, make the project-root layout mandatory for module-system packages. The quality gate and local mk_all must reject a flat LeanPool.lean even if every Imports.lean is deleted, and regenerate exactly one complete public aggregate per project. Keep independent legacy non-module fixtures supported; fix the rebase fast-path fixture to use valid TOML.
Validation: 561 Python tests passed (2 unrelated optional skips), including deletion of all aggregates, complete public export compilation, stale/missing/duplicate/private/cross-project imports, collision safety and mechanical rebase conflicts. Ruff, formatting and lake exe mk_all --module --check passed. The complete content migration passed whole-tree static quality checks before merge. No formalization sources, thresholds or branch protection settings change.