Repository navigation
Import each complete project through its generated root - #559
Merged
Merged
Conversation
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Medium risk] Adds generated import aggregator files for each project. No blocking defect was identified in the import migration, but a whole-tree Lean build and style validation remain to be confirmed before calling it safe to merge. SummaryReplaces the flat
Reviews (1) · Last reviewed commit: "Import each complete project through its..." |
This was referenced Oct 1, 2026
Contributor
Proof profile (new / modified Lean files)No proof profile output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the 9,999 leaf imports in LeanPool.lean with one public import per project. Add 255 generated LeanPool//Imports.lean files, each publicly importing its original entry module and every nested source exactly once. LeanPool.lean drops from 10,001 to 257 lines; the largest project aggregate has 1,593 lines.
All 9,999 existing mathematical source files and the registry remain byte-identical. Public import at both levels preserves access through LeanPool without adding definition exposure. This content-only migration uses the tooling merged in #558; mandatory enforcement follows separately.
Validation: exact full-tree source coverage and source-preservation audit passed, 561 Python tests passed (2 unrelated optional skips), including a real Lean public-export consumer, and lake exe mk_all --module --check passed. Whole-tree static quality checks passed. The cached VM lint-style binary is from an incompatible older toolchain, so Lean style validation remains with normal CI.