Repository navigation
Update Ladybug to v0.21.2 and fix auto-update workflow - #11
Merged
Merged
Conversation
- Bump Sources/LadybugCpp submodule v0.16.1 -> v0.21.2 - Regenerate Package.swift via collect-ladybug-src.py (1183 files; new GDS/FTS/arrow/graph sources, drop removed json_utils.cpp) - Default prebuilt liblbug version 0.16.1 -> 0.21.2 - Fix swift-docc-plugin spec in Package.swift and template (branch: -> from:, 1.4.5 is a tag)
The old updater cloned ladybug into Sources/Ladybug (real submodule is Sources/LadybugCpp), defaulted to a nonexistent 'master' branch, ignored subprocess failures, and never bumped the submodule pointer, so scheduled runs silently did nothing. - Resolve 'latest' to the newest vX.Y.Z tag (or accept an explicit tag) - Check out the tag in Sources/LadybugCpp + nested dataset/extension - Regenerate Package.swift, bump download-liblbug.sh default, validate the manifest; fail loudly on any error - Workflow takes a version input (default latest), names the PR branch after the resolved tag, and no longer auto-merges without review
- Mixed-type LIST/MAP parameters are coerced to a common type upstream
since 0.17 (tryGetMaxParameterType) instead of erroring: assert the
coerced strings ("4") rather than "same type" errors.
- Skip testGds when the published ALGO extension binary cannot be
loaded (upstream 0.21.0 artifact ships without usable libnetworkit
on macOS and Linux); any other failure still fails the test.
- collect-ladybug-src: drop out-of-package -I dirs (e.g. Homebrew
OpenSSL, new in 0.21.x via CPPHTTPLIB_OPENSSL_SUPPORT) and the SSL
define, which SwiftPM cannot express and xcodebuild rejects.
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored Ladybug C++ from v0.16.1 to v0.21.2 and fixes the broken auto-update workflow so future releases are picked up.
Ladybug v0.21.2
Sources/LadybugCppsubmodule v0.16.1 → v0.21.2 (+ nesteddataset/extension)Package.swiftviacollect-ladybug-src.py(1183 files: new GDS/FTS/Arrow/graph sources, removedjson_utils.cpp)LBUG_VERSION0.16.1 → 0.21.2lbug_default_system_config()+ per-field setters, so no wrapper changes neededswift-docc-pluginspecbranch: → from:inPackage.swift(fixes Package.swift: swift-docc-plugin declared withbranch: "1.4.5"but 1.4.5 is a tag; SwiftPM/Xcode resolution fails #9; 1.4.5 is a tag, not a branch)Auto-update workflow fix
Sources/Ladybug(real path isSources/LadybugCpp), defaulted to nonexistentmasterbranch, ignored failures, and never bumped the pointer — scheduled runs silently did nothinglatestto newestvX.Y.Ztag (or takes an explicit tag), checks out the submodule, regenerates, bumps prebuilt default, validates manifest, fails loudlyversioninput (defaultlatest); PR branch named after resolved tag; auto-merge removed so native bumps get CI + reviewVerified locally: manifest dumps clean, regen is deterministic, version switching works both directions,
latestresolves to v0.21.2.