Repository navigation
Make generated examples relocatable - #695
Merged
Merged
Conversation
vitenti
commented
Oct 23, 2026
vitenti
commented
Collaborator
- Behavior change: use_absolute_path now defaults to False, so the generated configurations name their files relative to the example directory and the frameworks run from that directory; pass --use-absolute-path for the previous behavior
- Load the CosmoSIS connector through firecrown_cosmosis.py, written next to the ini, which imports it from the installed Firecrown; the ini no longer records the connector's installed path
- Drop root from the generated ini, so that CosmoSIS resolves relative paths against the directory it runs from
- Write the cmb_cross experiment path relative unless use_absolute_path is set, as des_y1_3x2pt already does
- Check in the unit tests that no generated file names its directory or the Firecrown installation, and run a moved cosmic_shear with each framework in the example tests
- Checked locally: 4309 unit tests and 84 example runs pass
|
PR revision: Breaking API changes detected (1 findings). Informational because the target is PR public API verdictBreaking API changes detected (1 findings). Informational because the target is Target: Static analysis only: no behavioral compatibility guarantee or external-dependency signature analysis. Public API changes: d130a0f -> HEADExecutive summary
Breaking changes
New public APINone. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 163 163
Lines 9978 9979 +1
Branches 1199 1199
=======================================
+ Hits 9978 9979 +1
🚀 New features to boost your workflow:
|
* Write firecrown_cosmosis.py, which imports setup, execute and cleanup from the installed firecrown.connector.cosmosis.likelihood, and point the ini's firecrown_likelihood file at it instead of at the connector's installed path * Drop root from the generated ini, so that CosmoSIS resolves relative paths against the directory it runs from
* Behavior change: use_absolute_path now defaults to False, so the generated configurations name their files relative to the example directory and the frameworks run from that directory; pass --use-absolute-path for the previous behavior * Write the cmb_cross experiment path relative unless use_absolute_path is set, as des_y1_3x2pt already does * Run the example tests that build the likelihood from the example directory
* Check in the unit tests that the generated files of cosmic_shear and cmb_cross name neither their directory nor the Firecrown installation, and that the CosmoSIS ini loads the shim * Run cosmic_shear with each framework after moving its directory, in the example tests
vitenti
force-pushed
the
make-generated-examples-relocatable
branch
from
October 23, 2026 16:49
fc94845 to
0cff434
Compare
marcpaterno
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.