Repository navigation
Replace the non-developer mode example with a generated one - #696
Merged
Merged
Conversation
vitenti
commented
Oct 23, 2026
vitenti
commented
Collaborator
- Stacked on Make generated examples relocatable #695: merge Make generated examples relocatable #695 first
- Rewrite docs/non-developer-mode-example/README.rst around firecrown examples des_y1_3x2pt, with the command that runs it for each framework
- Delete the hand-written example, which no longer ran: its Cobaya configuration loads the nonexistent firecrown.connector.cobaya.ccl, its likelihood script reads a SACC file the docs do not provide, and its CosmoSIS ini uses the undefined FIRECROWN_SITE_PACKAGES
- Checked locally: the documented commands generate des_y1_3x2pt and run it with CosmoSIS, Cobaya and NumCosmo; the Sphinx build resolves both links of the page
|
PR revision: No breaking API changes detected. PR public API verdictNo breaking API changes detected. Target: Static analysis only: no behavioral compatibility guarantee or external-dependency signature analysis. Public API changes: fb5d141 -> HEADExecutive summaryNo breaking API changes detected. Breaking changesNone. New public APINone. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 163 163
Lines 9979 9979
Branches 1199 1199
=======================================
Hits 9979 9979 🚀 New features to boost your workflow:
|
vitenti
force-pushed
the
replace-non-developer-mode-example
branch
from
October 23, 2026 16:49
e80a715 to
00f719a
Compare
Base automatically changed from
make-generated-examples-relocatable
to
master
October 23, 2026 17:40
vitenti
force-pushed
the
replace-non-developer-mode-example
branch
from
October 23, 2026 17:40
00f719a to
37dbd5f
Compare
* Rewrite docs/non-developer-mode-example/README.rst around firecrown examples des_y1_3x2pt, with the command that runs it for each framework * Delete the hand-written example, which no longer ran: its Cobaya configuration loads the nonexistent firecrown.connector.cobaya.ccl, its likelihood script reads a SACC file the docs do not provide, and its CosmoSIS ini uses the undefined FIRECROWN_SITE_PACKAGES
vitenti
force-pushed
the
replace-non-developer-mode-example
branch
from
October 23, 2026 17:47
37dbd5f to
98ec463
Compare
marcpaterno
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.