Fixes multiple bugs related to BBEditor and time signatures#6096
Open
sdasda7777 wants to merge 2 commits into
Open
Fixes multiple bugs related to BBEditor and time signatures#6096sdasda7777 wants to merge 2 commits into
sdasda7777 wants to merge 2 commits into
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Windows
macOS🤖{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/bbe1645b-f462-4adf-9b93-7e1bb2e71891/artifacts/0/lmms-1.3.0-alpha.1.160+ge5b900752-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17609?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/6bbbc35a-a91e-4dad-a80b-fdac4660be08/artifacts/0/lmms-1.3.0-alpha.1.160+ge5b900752-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17607?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://output.circle-artifacts.com/output/job/949cbbbe-c60a-4900-bc3f-3d51a2df766f/artifacts/0/lmms-1.3.0-alpha.1.160+ge5b900752-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17608?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "66d2886be1d878f0bc1c1b39141573832b1e4f7c"} |
Member
|
It seems like |
Author
|
You're right, that seems to do the trick |
PhysSong
reviewed
Jul 24, 2021
ac9cf2e to
66d2886
Compare
66d2886 to
3f0c3ba
Compare
Contributor
|
I fixed the comically absurd diff† by cherry-picking‡ the two commits that actually matter for this PR onto current
‡ Rewrote the equivalent, since files and classes have all been renamed since the original commits were made lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes multiple bugs related to BBEditor and time signatures, stemming from incorrect or outdated usage of method getBar():
Line 575: Fixes the issue that if new BB subtrack is added when time signature isn't n/n, due to the way getBar() works the result wouldn't be the one the formula using it was hoping for, and, for example, subtrack added at time signature 8/4 would only appear on every other BB track (subtrack for track 1 would appear on track 2, for 2 on 4, etc.).