Skip to content

Fixes incorrect BB tracks being shown in the BB Editor (#6079)#6080

Closed
sdasda7777 wants to merge 1 commit into
LMMS:masterfrom
sdasda7777:BBEditorTimeSigFix
Closed

Fixes incorrect BB tracks being shown in the BB Editor (#6079)#6080
sdasda7777 wants to merge 1 commit into
LMMS:masterfrom
sdasda7777:BBEditorTimeSigFix

Conversation

@sdasda7777

Copy link
Copy Markdown

Fixes issue 6079, that is incorrect BB tracks being shown in the BB Editor.
The fix achieves this by not using getBar for calculating the number of the track (as that doesn't work with different signatures than n/n), and instead gets track number by dividing by DefaultTicksPerBar.

@LmmsBot

LmmsBot commented Jul 13, 2021

Copy link
Copy Markdown
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://14260-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.121%2Bg717e5ef-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14260?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://14256-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.121%2Bg717e5efbd-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14256?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://14257-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.121%2Bg717e5efbd-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14257?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/4fruxa6j89r2ps7j/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/39978425"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/s0bhw6bkux22i72o/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/39978425"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://14258-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.121%2Bg717e5efbd-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14258?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "20af0fe144e367ff7f315a60e4c1c39ef8bd6555"}

@sdasda7777 sdasda7777 changed the title Fixes #6079 Fixes incorrect BB tracks being shown in the BB Editor (#6079) Jul 13, 2021
@sdasda7777

Copy link
Copy Markdown
Author

#6096 is in the same file, so please do not pull this one.

@sdasda7777 sdasda7777 closed this Jul 17, 2021
@Veratil

Veratil commented Jul 17, 2021

Copy link
Copy Markdown
Contributor

Why didn't you just add the commit to this PR?

@sdasda7777

Copy link
Copy Markdown
Author

To be perfectly honest, I'm bit of a noob and didn't know that was a thing.

@Veratil

Veratil commented Jul 17, 2021

Copy link
Copy Markdown
Contributor

To be perfectly honest, I'm bit of a noob and didn't know that was a thing.

All good! Next time you know you can just add to the same branch and push and it updates automagically here. :)

@sdasda7777

Copy link
Copy Markdown
Author

I see, thanks

@sdasda7777 sdasda7777 deleted the BBEditorTimeSigFix branch June 28, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants