Fixes incorrect BB tracks being shown in the BB Editor (#6079)#6080
Closed
sdasda7777 wants to merge 1 commit into
Closed
Fixes incorrect BB tracks being shown in the BB Editor (#6079)#6080sdasda7777 wants to merge 1 commit into
sdasda7777 wants to merge 1 commit into
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://14260-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.121%2Bg717e5ef-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14260?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://14256-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.121%2Bg717e5efbd-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14256?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://14257-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.121%2Bg717e5efbd-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14257?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/4fruxa6j89r2ps7j/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/39978425"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/s0bhw6bkux22i72o/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/39978425"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://14258-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.121%2Bg717e5efbd-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14258?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "20af0fe144e367ff7f315a60e4c1c39ef8bd6555"} |
Author
|
#6096 is in the same file, so please do not pull this one. |
Contributor
|
Why didn't you just add the commit to this PR? |
Author
|
To be perfectly honest, I'm bit of a noob and didn't know that was a thing. |
Contributor
All good! Next time you know you can just add to the same branch and push and it updates automagically here. :) |
Author
|
I see, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 6079, that is incorrect BB tracks being shown in the BB Editor.
The fix achieves this by not using getBar for calculating the number of the track (as that doesn't work with different signatures than n/n), and instead gets track number by dividing by DefaultTicksPerBar.