Skip to content

i18n: change installation references to updating - #731

Merged
KnifeLemon merged 17 commits into
KnifeLemon:mainfrom
adnan-bhaldar:i18n/update-status-copy
Oct 28, 2026
Merged

KnifeLemon merged 17 commits into
KnifeLemon:mainfrom
adnan-bhaldar:i18n/update-status-copy

Conversation

@adnan-bhaldar

Copy link
Copy Markdown
Contributor

Tip

Start the title with a prefix so the PR is labeled automatically: feat: fix: docs: ci: build: i18n:
Example: fix(hwp): keep tables when converting to DOCX

What does this change?

Updates localization strings across all supported language files (src/Filee.App/Assets/i18n/*.json) to change update.installing_short references from "Installing" to "Updating".

  • Why: Since the application is already installed, the process is an update rather than a fresh installation. Using "Updating" ensures accurate terminology, logical consistency across all supported languages, and aligns with the English source copy. Minor downloading phrasings (such as refining articles in Portuguese) were also tuned for a cleaner user experience.

Type of change

  • Bug fix
  • New feature or improvement
  • New format or engine
  • Translation
  • Documentation
  • Build, CI or dependencies

How was it tested?

  • dotnet format --verify-no-changes
  • dotnet test
  • Tried it in the app (verified updated localization strings across multiple language locales).

Screenshots (UI changes)

Checklist

  • New UI strings are in all src/Filee.App/Assets/i18n/*.json files
  • New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md
  • The PR does one thing (unrelated changes go in a separate PR)

@github-actions github-actions Bot added the translation UI translations and language support label Oct 28, 2026
The download line changes are left out: they dropped the article the other
lines use, and in French the narrow no-break space before % (which keeps
the number and % on one line).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@KnifeLemon

Copy link
Copy Markdown
Owner

Thanks, @adnan-bhaldar! "Updating…" fits better while the installer runs over an installed copy. I pushed one commit on top:

  • German: de.json was missing; it now reads "Wird aktualisiert…".

  • The download line stays as it was:

    • The changes there dropped the article the neighbouring lines use ("Downloading the update…", "Descargando la actualización…").
    • In French the narrow no-break space before % became a plain space, which lets the % wrap onto its own line.

    Those weren't part of the "Installing → Updating" fix, so I left them out.

I'll merge once CI is green.

@adnan-bhaldar

Copy link
Copy Markdown
Contributor Author

UI microcopy thrives on conciseness. Dropping articles like "the" from "Downloading the update…" reduces visual noise and allows the eye to process the core message and the percentage number instantly.

@KnifeLemon

KnifeLemon commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Fair point for the sidebar button and the tray, where space is short. The catch is that update.downloading isn't only the short label: the same key is also the full status sentence on the About page, in the update notice and in the progress window, which is where "the" reads naturally. Dropping it in four languages here would also leave the other thirteen with the article.

If the short spots should be shorter, the clean way is a key of their own, like update.installing_short already is. For example, update.downloading_short: "Downloading… {0}%" in all 17 languages, used by UpdateTexts.Short. The full sentence stays as it is. That would be a good follow-up PR if you'd like to take it.

This one goes in as "Installing → Updating" once CI is green.

@KnifeLemon KnifeLemon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adnan-bhaldar!

@KnifeLemon
KnifeLemon merged commit 58bbe56 into KnifeLemon:main Oct 28, 2026
6 checks passed
@adnan-bhaldar

adnan-bhaldar commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Yes, I'd be happy to handle that! Please assign it to me, and I'll open a follow-up PR for update.downloading_short once this current PR is merged. @KnifeLemon, should I go ahead and open a tracking issue for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation UI translations and language support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants