Repository navigation
i18n: add update.downloading_short for the sidebar button and the tray - #749
Merged
KnifeLemon merged 20 commits intoOct 29, 2026
Merged
Conversation
The short label used update.downloading, the full status sentence, so it
carried the article ("Downloading the update… 42%"). It now has a key of its
own, "Downloading… {0}%", in all 17 languages. The full sentence stays as it
is on the About page, the update notice and the progress window.
French keeps the no-break space before the %, as in update.downloading.
Tests check that every language has the key, that it is shorter than the
full sentence, and that both end alike from the "…" on.
KnifeLemon
approved these changes
Oct 29, 2026
KnifeLemon
left a comment
KnifeLemon
left a comment
Owner
There was a problem hiding this comment.
Thanks, @adnan-bhaldar! The short key reads well in every language, and French keeps the no-break space before %.
One note: the description mentions two new tests (the short label being shorter, and UpdateTexts.Short using the short key), but no test file is in the diff. Not blocking: the existing localization tests check that every language has the key and the same placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
Start the title with a prefix so the PR is labeled automatically:
feat:fix:docs:ci:build:i18n:Example:
fix(hwp): keep tables when converting to DOCXWhat does this change?
Follow-up to #731, as suggested there.
UpdateTexts.Short(the sidebar button and the tray) showedupdate.downloading, the full status sentence.It now uses a new key,
update.downloading_short: "Downloading… {0}%" in all 17 languages.update.downloadingis unchanged and still used byUpdateTexts.Status(About page, update notice, progress window).Type of change
How was it tested?
{0}placeholder (the existing localization tests).UpdateTexts.Shortuses the short key while downloading, andStatuskeeps the full sentence.dotnet format --verify-no-changes,dotnet testChecklist
src/Filee.App/Assets/i18n/*.jsonfilesTHIRD-PARTY-NOTICES.md(none)