Repository navigation
Conversation
Recognize the oscilloscope marker and tab-separated measurements, preserve their text as CSV, and offer the existing CSV preset on text donuts. Addresses KnifeLemon#571.
This was referenced Oct 28, 2026
Owner
|
Thanks, @Stamina9! The converter and its tests are good. One change: the CSV slot on the text donut would show for every This branch doesn't allow edits from maintainers, so I've carried your commit over unchanged (you stay its author) with that change on top in #721, and I'm closing this one in favour of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Convert FreeMASTER oscilloscope TXT exports to CSV. The sample in #571 contains a
# Oscilloscope Datamarker, a tab-separated header and 29 columns of readings. The converter preserves each field as text, including empty fields and leading zeroes.This is deliberately limited to identified FreeMASTER exports: ordinary TXT and files with inconsistent column counts are refused with an explanatory error. The new TXT → CSV edge is direct-only so it does not change existing multi-step text routes. The existing CSV preset is offered on the text donut; schema 55 adds it to existing profiles when a slot is available and the user has not placed it already.
Addresses #571.
Type of change
How was it tested?
dotnet format Filee.slnx --verify-no-changes --no-restoreScreenshots (UI changes)
The existing CSV preset is added to the text donut back face; no new UI strings.
Checklist