Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Releasing @kikobeats/got ran from a script on one machine. A release job now runs after the tests on every push to v11: it publishes, tags and creates the GitHub release only when package.json's version is not on npm yet, so merging a backport changes nothing and merging a version bump releases it. Needs an NPM_TOKEN secret with publish access. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
d205914 to
1c7c39e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1c7c39e. Configure here.
| if: steps.version.outputs.publish == 'true' | ||
| run: | | ||
| RUNTIME_DEPENDENCIES=$(node -p "Object.entries(require('./package.json').dependencies).map(([name, range]) => name + '@' + range).join(' ')") | ||
| npm install --ignore-scripts --no-save $RUNTIME_DEPENDENCIES pem@$PEM_VERSION @types/node@$TYPES_NODE_VERSION |
There was a problem hiding this comment.
Missing token breaks release job
High Severity
setup-node with registry-url writes an .npmrc that interpolates NODE_AUTH_TOKEN, but the version check and install steps never set that variable. npm fails while expanding the config, so the already-published check always takes the publish path and install dies. Every push to v11 fails Release, and a new version cannot be published.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1c7c39e. Configure here.
|
Superseded by #9, which publishes from CI with automate-release release scripts adapted to v11 (standard-version bump, CHANGELOG, tag, GitHub release, ci-publish). |


Publishing
@kikobeats/gotcurrently depends on a script that exists on one machine. This moves it into CI, in the same shape as is-antibot's release job, adapted to how this fork releases.How it works
A
releasejob runs after the tests on every push tov11:versionfrompackage.jsonand checks npm;npm publish --access=public, tagsv$VERSIONand creates the GitHub release with generated notes.So merging a backport publishes nothing, and merging a version bump (like #5 for 11.8.8) releases it. Unlike is-antibot, nothing bumps the version automatically:
v11carries backports, not conventional-commit features, so the version stays a deliberate change in a PR.The pinned install (dev dependencies as of
2021-06-15,pem@1.14.8,@types/node@14.18.34) is needed becausenpm publishrunsprepare, which builds with the TypeScript version this branch pins.Required secret
NPM_TOKEN, an npm automation token with publish access for the@kikobeatsscope. This repository currently has no secrets; is-antibot usesNPM_TOKEN,GH_TOKEN,GIT_EMAIL,GIT_USERNAME. Tagging and the GitHub release use the built-ingithub.token(the job declarescontents: write), so no other secret is needed.Until the secret exists, a version bump will fail in the publish step. The tests are unaffected.
Testing
releasejob hasneeds: [test],if: github.event_name == 'push'andpermissions: contents: write, so it never runs on pull requests.11.8.8reports "already published" and writes nothing,11.8.9writespublish=true.v11packs@kikobeats/got@11.8.8withnpm pack --dry-runand exit 0.After this merges,
~/Downloads/publish-kikobeats-got.shcan be deleted.🤖 Generated with Claude Code
https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC