Repository navigation
ci: automate release - #10
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Keeps got's scripts, TypeScript build, xo, ava 3 and nyc instead of the automate-release defaults, and releases from v11 with npm: - package.json: got's original file plus the release scripts, commitlint and simple-git-hooks (commit-msg only). np is replaced by standard-version, conventional-changelog-cli and ci-publish. github-generate-release runs through npx because it postdates the 2021-06-15 dev dependency pin. nano-staged is left out for the same reason. - .github/actions/install: got's pinned dev dependency install, shared by every job. It installs without runtime dependencies so aliases newer than the pin still resolve in the next step. - pull_request.yml: xo on Node.js 22 (xo 0.34 calls util.isDate, removed in Node.js 23) and the lts/latest build + nyc ava matrix. Also callable from main.yml. - main.yml: on push to v11, runs pull_request.yml, then npm run release. No contributors job: git-authors-cli would rewrite the contributors list from upstream got's history. - test.yml is removed; pull_request.yml and main.yml replace it. - test/helpers/invalid-url.ts imports ava the way the other helpers do, fixing xo's ava/use-test error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Kikobeats
marked this pull request as ready for review
September 17, 2026 14:05
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases
@kikobeats/gotfrom CI, using automate-release's layout while keeping got's own toolchain (xo, TypeScript 4.0 build, ava 3, nyc).What changed from the automate-release defaults
test: c8 avareplacedpackage.jsonkept as-is, release tooling addedmasterv11v11and pins dev deps withnpm install --beforeconventional-changelogconventional-changelog-cliconventional-changeloghas no CLIgithub-generate-releasedevDependencynpx -y github-generate-releasenano-stagedpre-commit (standard)nano-stagedalso postdates the pin, and the fork lints TypeScript with xogit-authors-cliwould rewrite contributors from upstream got's historyFiles
package.json: scriptsrelease,postreleaseandrelease:*(standard-version bump,CHANGELOG.md,chore(release): x.y.zcommit, tag,git push origin HEAD:v11 --follow-tags, GitHub release,ci-publish || npm publish).npremoved; commitlint + simple-git-hooks added..github/actions/install: got's pinned install, shared by every job. Runtime deps are removed for the pinned step so aliases newer than the pin (fix: depend on @kikobeats/cacheable-request #9) still resolve.pull_request.yml: Lint runsnpx xoon Node 22 (xo 0.34 callsutil.isDate, removed in Node 23), plus a build +nyc avamatrix on lts/* and latest. Also callable frommain.yml.main.yml: on push tov11, runspull_request.yml, thennpm run release. Skipped forchore(release):,docs:andci:commits.test.yml: removed, replaced by the two workflows above.dependabot.yml:target-branch: v11, since the default branchmasteris got 6.test/helpers/invalid-url.ts:import * as test from 'ava', like the other helpers. Fixes xo'sava/use-testerror.Tested
v11: 11.8.8 → 11.8.9,CHANGELOG.mdcreated,chore(release): 11.8.9commit, tagv11.8.9, both pushed. The GitHub release and npm publish weren't run.Before merging
v11. Merging this releases, and 11.8.9 should include fix: depend on @kikobeats/cacheable-request #9's alias.NPM_TOKEN,GH_TOKEN,GIT_EMAIL,GIT_USERNAME. My token can't list secrets, so check they exist.🤖 Generated with Claude Code
Note
Medium Risk
Automated npm publish and git tagging on every qualifying
v11push depend on secrets and commit-message skips; workflow mistakes could ship unintended versions.Overview
Adds CI-driven releases on pushes to
v11: lint (xoon Node 22) and build/test (nyc+avaon LTS/latest) run via reusablepull_request.yml, then a release job runsnpm run releaseunless the commit ischore(release):,docs:, orci:.Release tooling drops
npin favor ofstandard-version, changelog generation, git tag/push tov11, GitHub release (github-generate-release), and npm publish (ci-publishfallback). commitlint + simple-git-hooks validate commit messages locally.Shared composite install action centralizes the pinned dev-deps + latest-in-range runtime install (replacing inline steps from the old
test.yml). Dependabot targetsv11for npm and GitHub Actions (Actions limited to major bumps). Minor test helper change:invalid-url.tsusesimport * as test from 'ava'for xo.Reviewed by Cursor Bugbot for commit 0157579. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Chores
Refactor
Bug Fixes
Chores