Skip to content

Document conditional cloud review and optional human review - #101

Draft
antuz123 wants to merge 8 commits into
mainfrom
codex/desktop-review-owners
Draft

antuz123 wants to merge 8 commits into
mainfrom
codex/desktop-review-owners

Conversation

@antuz123

@antuz123 antuz123 commented Oct 7, 2026 •

Copy link
Copy Markdown

Cloud review now depends on actual severity, uncertainty, scope and cost; human developer review stays optional. Verified routine documentation, noncritical copy or pure style may skip a separate provider review with reason/evidence, but policy/security/agent/workflow documents cannot Skip. Bounded normal changes use Lite; signing, keys, authentication, recovery/backup, pairing, transactions, migrations, workflows, permissions, security dependencies/copy, cross-service/complex changes and unknown risk use Balanced.

Use the least-cost adequate authorized route, reuse valid exact-head/base coverage, make one initial review after stable checks and batch material fixes before necessary re-review. Independent coverage is needed only when an actual risk/finding requires it and an installed, authorized route/scope/budget exists. If scope, quota, cap or activation is unavailable, record unavailable and use another already-authorized adequate route or hold the applicable gate. Do not downgrade critical review, add paid retries/fallbacks or infer fresh allowance. Existing caps and historical balances do not activate a reviewer or grant budget; ordinary within-scope/allowance review does not need repeated permission.

Actual findings/dispositions, reviewed SHA/base/coverage and skipped/pending/unavailable results must be recorded. Required CI/status checks, substantive security concerns, native/device validation, product signoff and operation-specific signing/deployment/release authorization remain intact. Existing comment-only human CODEOWNERS suggestions remain optional and require no access grants.

Policy/docs/templates/agent instructions only: no runtime, workflow, R5 implementation, permission, secret, budget, merge or deployment change. No new provider request or paid review is claimed. Current recorded Copilot ready-PR automation, plus mobile every-push review, does not implement conditional triage; Markdown does not fix settings or install mobile reviewer #7049. Keep source preparation and installed automation status separate.

Historical receipts remain tied to exact original commits. Record current-head validation separately; skipped/unavailable review is not a clean review.

Current conditional-policy head: 76d2415bdbcb1a157e267147c65bff371fd7877d. An existing cloud agent who did not author these policy edits independently reviewed the exact prepared patch (manifest SHA-256 a0bf37b7be612932af8911e329899178f7db123c6b66aa0cd2a492df108b6a5a); no blocking finding. This is cloud-agent source evidence, not a completed Copilot/Claude provider review or formal GitHub approval. Fresh exact-head CI evidence follows. Policies remain draft/unmerged and live GitHub rules are unchanged: administrator access is still needed to remove enforced human approval and implement conditional triggering. No ready transition or new provider/paid review was requested.

Fresh exact-head CI: Fresh exact-head CI39733638735/job119674174944 passed ESLint, Prettier, Rust formatting and Clippy. Only one ordinary pull_request CI run executed at this head; no release, PGP, signing or publication workflow ran. This is Linux source verification, not native/device acceptance.

The owner has directed progressing the prepared SigningServer/Desktop source changes after actual optional-human configuration and applicable cloud review/required checks. Integrate guardPR102 first, refresh this policy PR onto the resulting main, retain integrated CI bytes and rerun exact-head checks before integration. An existing GitHub administrator execution route remains missing; no additional generic source approval is required. Native signing/notarization/distribution retain their specific authorization.

@antuz123
antuz123 requested review from ben-kaufman and cakesoft-utkarsh and a balanced review from Copilot October 7, 2026 12:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The CODEOWNERS syntax and placement correctly implement the stated review policy.

Review effort: Balanced
Findings: None

What changed in this PR

Adds default code owners for all Desktop repository changes.

Changes:

  • Requests reviews from Ben and Utkarsh on future PRs.
  • Documents that only one approval is required.
File Description
.github/​CODEOWNERS Assigns both developers as code owners for all files.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@antuz123 antuz123 changed the title Request Ben and Utkarsh on future Desktop PRs Request Ben, Utkarsh, and Parsh on future Desktop PRs Oct 7, 2026
@antuz123
antuz123 marked this pull request as draft October 7, 2026 12:33
@antuz123 antuz123 changed the title Request Ben, Utkarsh, and Parsh on future Desktop PRs Set Desktop reviewers and Copilot review policy Oct 7, 2026

Copy link
Copy Markdown
Author

Cloud review-policy dependency check — 12 October 2026

Current source head 00f1725beb2b00199f9c15828e1a91cafe632761 is unchanged; exact-head hosted CI is successful. Public GitHub permission read reports Ben=write, Parsh=read, Utkarsh=admin. Read access does not establish accepted CODEOWNERS write access. Keep this unapproved PR draft while the documented access dependency remains open; verify all intended owners before ready/merge. No invitation, role, review effort/quota, permission or branch-protection setting was changed. No fresh Copilot review was requested. Documentation review does not need native Mac testing, and no source-policy approval substitutes for app/Desktop/backend or release acceptance.

@antuz123 antuz123 changed the title Set Desktop reviewers and Copilot review policy Document optional human reviewers and Copilot review policy Oct 22, 2026
@antuz123 antuz123 changed the title Document optional human reviewers and Copilot review policy Document conditional cloud review and optional human review Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants