Repository navigation
Conversation
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful QA build currently starts the PGP workflow, which can select an unrelated draft by version substring and replace checksum assets. Replace automatic signing/upload with a manual, read-only preflight bound to an exact source SHA, production release ID/tag, successful production build run and complete asset IDs/hashes.
The guard rejects QA/dev runs, repository/source/workflow mismatches, failed or skipped packaging, changed/incomplete assets and existing checksum/signature outputs. Checkout is pinned to the reviewed v4 commit and immutable workflow source. The workflow has no release secrets, signing, upload or publication path. A future signer must independently validate downloaded bytes, trust and operation-specific authorization; PREFLIGHT_ONLY is not signing permission. Ordinary CI explicitly installs rustfmt and Clippy for its unchanged Rust 1.85.1 checks.
Exact source:
06233e6a576ae1c9d0a49a34c253b3e9354b9efc, base627c92a8d7b260047b5566b447685e9cfa7e0e15. The three guard files remain byte-identical to approved patch SHA-256f94930bfcb7e2866d4c00bc4b345bed91d5aebf2db73e494c23b96a638a6e231; the two-line CI prerequisite patch isb4447ba86d336248ee806507bf15c248c43f522bbaa231041eccb83164779d0c. Exact-head ordinary CI passes ESLint, Prettier, Rust formatting and Clippy. All 12 guard fixtures pass locally, including an independent rerun; ordinary hosted CI does not execute those Python fixtures. Python compile, YAML/read-only/pinned checkout contracts and Bash syntax pass. actionlint was unavailable.Conditional cloud review decision: Balanced risk tier. Actual route: an existing independent Codex cloud-agent source peer check; this does not claim a Copilot Balanced setting or an Anthropic model/effort selection.
Review evidence: release-workflow controls warrant deeper independent source review. An existing Codex cloud agent who did not author the guard reviewed all four exact remote blobs, input/shell separation, permissions, validation cases and merge side effects; no blocking source issue was found. This is cloud-agent peer evidence, not a Copilot/Claude provider review or formal GitHub approval. No additional paid provider request was used. Receipt: /workspace/r4-closeout/desktop-pr102-cloud-peer-review.json.
The owner directed progressing the prepared SigningServer/Desktop changes once human reviews are optional and applicable cloud review and required checks pass. Human developer approval is optional by policy. Existing GitHub administrator access is still needed to verify/remove any legacy approval requirements and implement conditional review triggering; no bypass is used. The PR remains draft while that configuration blocker is unresolved. The current main branch retains the old automatic PGP workflow until source integration occurs.
Integrate this guard before refreshing policy PR #101: both branches independently added equivalent Rust components in a different order, so refresh #101 against the resulting main, retain the integrated CI bytes and rerun its exact-head checks. Do not carry old CI receipts across the new source/base.
Merging this source change runs ordinary main CI; it does not start the release/dev-release builders or the manual preflight. Native builds, phone-to-Desktop pairing, hardware acceptance, signing, notarization and production distribution remain separate gates. No production release operation is included.