Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
These narrow changes introduce no identified blocking issues, though mobile end-to-end verification remains pending.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns Desktop development builds with the active Keeper channel already used by release builds.
Changes:
- Uses the active channel endpoint for all builds.
- Explicitly installs Rust formatting and linting components in CI.
| File | Description |
|---|---|
src-tauri/src/channel.rs |
Removes the development-only endpoint; release behavior stays unchanged. |
.github/workflows/ci.yml |
Adds rustfmt and clippy to toolchain installation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codex local handoffState: NEEDS_LOCAL
|
R4 paired-mobile continuation — 13 October 2026Desktop source is unchanged at Pair native acceptance with Keeper #7045 exact head State: NEEDS_LOCAL. Follow this Desktop exact-head handoff, retain the separate QA identity and preserve existing apps/wallets. Record actual Desktop launch and paired iOS/Android QR readiness, reconnect/cancel/retry/duplicate handling, authenticated malformed/old-room rejection and available signer/address/policy/PSBT round trips. Report unrun physical scenarios explicitly with owner follow-up; do not infer device acceptance from Cloud or an owner deferral. Production signing, notarization, artifact identity and publication remain separately gated. No merge, deployment, release signing, upload, publication or broadcast is authorized. |
R4 / 2.6.4 scope
All unfinished R3 pairing work is carried into R4. This PR remains the Desktop source candidate; normal independent review, signing, notarization, and owner phone/Desktop/hardware acceptance gates still apply. No production release is created by this PR.
Changes
Verification
Current head
ef050663d33be51f25fb10310d5a0549b111e273: local frontend request tests 7/7, ESLint, Prettier check, TypeScript/Vite build, and diff check passed. The build retains an existing CSS comment warning. Hosted CI run 37928029388 passed ESLint, Prettier, frontend request tests, Rustfmt, Clippy, and 9/9 Rust channel protocol tests. QA-only run 37928395053 built and uploaded artifact11615331902on this exact head; the production publish job was skipped. The artifact outer ZIP SHA-256 is2a3ca33dd9a539323f41639d98fb36ab8d2cdc670f1b17b20f861b3528eaeea5, enclosed QA ZIP SHA-2569ae0c39eefafd85a9234bf7a599f75e3b13a481ab0ad7f9418eee66990c34a69, executable SHA-25613e252b7a7f339d24e327d8d14d7956946f21b929c037970edffa9e6e90fcb70. The evidence file names this source SHA, version0.2.6-qa.1, separate identitycom.keeper.desktop.r3qa, and live endpoint; local strict deep code-signature verification passed. A current-head UI/channel smoke is pending.Previous head
f8bb96a6143a2738a7653a964dd9e2491e9966f5passed CI run 37627726045, including six Rust protocol tests. Its QA build 37627717543 produced artifact11484613811: macOS arm64 version0.2.6-qa.1, identitycom.keeper.desktop.r3qa, QA zip SHA-2561240f8d3132398b470d3a1870b4618c571f9d110110dc29530f4593ed0ba5c6b, executable SHA-25656dc6a5aaad076eb4e771a060ac54e8800615584632fb1efe36ecbbea4d7ce2a. That artifact predates the current packet-validation changes.On the previous QA app, a disposable live-channel smoke used the exact mobile #7024 AES-GCM module: an altered-tag TESTNET request left the QR screen unchanged, then a valid encrypted ADD_DEVICE/LEDGER request opened Connect Ledger. The session ended before Continue or any hardware action. This checks packaged Desktop receipt and decryption; it does not exercise Android scanning, request retries, or physical devices.
Open gates
Utkarsh approved exact head
ef050663d33be51f25fb10310d5a0549b111e273on 9 October 2026; Ben's request remains open. That satisfies the documented one-independent-developer source approval, but does not establish native or hardware acceptance. The earlier Copilot review coveredf8bb96a, not this head. Current-head CI and QA source/artifact checks are complete; a current-head UI/channel smoke remains open. The diagnostic Android build in draft #7045 uses a placeholder Relay and cannot reach the native scanner through fresh onboarding. Owner phone, Desktop, and hardware acceptance remains retrospective. No transaction was signed or broadcast, and no production deployment was performed.