Skip to content

ci: reconcile canonical iOS startup diagnostics - #7118

Merged
antuz123 merged 2 commits into
codex/r5-cloud-integration-20261022from
codex/r5-ios-diagnostic-reconciliation-20261022
Oct 22, 2026
Merged

antuz123 merged 2 commits into
codex/r5-cloud-integration-20261022from
codex/r5-ios-diagnostic-reconciliation-20261022

Conversation

@antuz123

@antuz123 antuz123 commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Historical PR-state note: GitHub automatically marked this draft merged when its isolated integration base advanced on22October21:53UTC. No PR merge API/command or shared/protected-branch promotion was performed. The review should have used a fixed base. Source ba8c6958b214920a56c06ee78db8c87a40ebf237 and original patch links remain preserved; replacement draft #7120 provides the same scoped review against fixed80199. This auto-classification supplies no merge, native or release approval.

The two completed iOS diagnostic packages used overlapping receipt schemas. This draft merges the original #7116 startup checkpoint by ancestry and retains #7115's reviewed pure classifier, cleanup and normal Metro behavior, with the additional bounded startup facts.

Head: ba8c6958b214920a56c06ee78db8c87a40ebf237; branch codex/r5-ios-diagnostic-reconciliation-20261022.
Parents: integration 80199f90b3f64869d9998e0984450c1b670c87b4 and original #7116 startup 76d1c949d91c5d885fc002f689a9ec321c16eafb.
Base: isolated integration branch codex/r5-cloud-integration-20261022, verified at 80199 before push.

Bounded Stage A patch: six diagnostic/test/doc files, 416 additions/72 deletions, approximately 8k changed source/test/doc tokens. App source, dependencies, UI flows/assertions, native commands/timeouts, SDK inputs, workflows, scheduling and gates are unchanged.

Reconciled behavior

  • ios_startup_errors.py remains the only compact-log classifier. Its strict framing, actual date/type/PID/severity validation, control-character rejection, truncation/size/scan limits and UNKNOWN/PARTIAL semantics remain. Canonical category names are retained; fixed ATS/Hermes and additional bounded bundle/dyld/React-fatal markers are incorporated. Cause remains UNDETERMINED; no duplicate parser or legacy aliases are introduced.
  • iOS hierarchy facts recognize fixed Login, Welcome Back, credential-error/Retry and modern LogBox markers. Missing, invalid, oversized or excess snapshots yield UNKNOWN and null flags. Parsed facts explicitly describe ANY_RETAINED_SNAPSHOT, not a final route, current visibility or delivered tap.
  • iOS Metro facts disclose bounded row/scan/export counts and caps. Missing observations remain UNKNOWN; invalid rows, truncation or a possibly reached producer cap cannot claim complete coverage. Future rows remain UNKNOWN. Existing Android execution and receipt fields are retained.
  • Normal Metro middleware/reporter/platform matching and all private-file purge/primary-failure preservation remain unchanged from the reviewed ci: retain bounded iOS startup error and Metro observations #7115 implementation. No new iOS service/process query is added; process state is explicitly UNKNOWN.

Actual exact-head checks

At ba8c695, clean committed source:

  • 416 Node22.23.3 controls PASS, zero fail/cancel/skip/todo.
  • 244 Python controls PASS, no failures or skips.
  • Three native-workflow actionlint checks and whitespace: PASS.
  • Independent coordinator review of the full six-file diff and 66 additional startup Python controls PASS; no concrete blocker.

Receipt SHA256: b7449369fadf303ac99210a5f156ab01e80e6190b8dda09ddff6f96557eb7ae2. Exact-head logs and receipt are retained in the Cloud evidence workspace. Actual hosted origin push run39859716442 / job120106964791, attempt1: 285 Node tests PASS, zero failures/cancellations/skips/todos. Raw checkout and both before/final source receipts identify exact ba8c head; push workflow SHA also equals that head. Raw log SHA256: abf43a3e6251157f70fa92a1d5af162f019948a74a1805ad0580dc4e8dbc0754. This hosted result covers the read-only origin contracts; the full416 Node/244 Python results above were executed separately on the exact committed Cloud checkout. No producer or tree-equivalent result is assigned to this SHA.

The push server reports inherited default-branch dependency inventory:199 findings,3 critical/111 high/72 moderate/13 low. This package makes no dependency/security clearance claim.

Preserved producer scopes and remaining work

  • #7115, eceb5551a430a0e31cff7a32d70181ee55007b69, already included in 80199; original patch.
  • #7116, original startup 76d1c949d91c5d885fc002f689a9ec321c16eafb; original patch.
  • Later producer checkpoint 1bc34890cb8618b2fffd446a63924974e0fe15b5 adds failure-only product JUnit/hierarchy/owned-Metro-window observations. That is a separate stacked Stage B, currently prepared locally and awaiting independent review. It is excluded from Stage A's patch and acceptance claims.
  • Producer native run39858617273 remains preserved at1bc, with its own exact-source outcomes. This draft adds no native opt-in/label/job and does not interrupt, cancel or duplicate that window. Recheck newer source/handoffs and active/native outcomes before selecting any future combined window.

The preserved23f iOS startup assertion and Android first-product sample failed. Progress through Skip does not establish the failed action or cause. This diagnostic preparation implements no app/selector fix and supplies no new native, performance, physical, backend, installed trusted-gate or release acceptance. Five startup/first-wallet sample pairs remain required. 5.2 is unidentified and excluded; 5.1/5.2 have not been tested together.

Codex local handoff

State: NEEDS_LOCAL
PR: #7118
Base: codex/r5-cloud-integration-20261022
Head branch: codex/r5-ios-diagnostic-reconciliation-20261022
Head commit: ba8c695
Goal and acceptance criteria: Reconcile bounded privacy-safe iOS startup facts while preserving the canonical classifier, original outcomes and all cleanup guarantees.
Changes made: Six diagnostic/test/doc files; original producer ancestry preserved.
Cloud checks: Exact416 Node/244 Python/actionlint3/whitespace PASS; independent66 Python/source review PASS. Hosted origin push39859716442/job120106964791 PASS285 Node with2 exact-source receipts; native iOS/Android on this head NOT RUN.
Required local checks: IOS, ANDROID
Local checks requested: Future independently reviewed combined hosted macOS/iOS→Android window after the active producer finishes naturally; no window selected by this draft. No personal Mac required.
Risks / known gaps: Startup/product causes UNKNOWN; diagnostic markers grant no native/physical/backend/security/trusted-gate acceptance; Stage B and unidentified5.2 remain separate.
Release readiness: NOT READY. No merge, shared promotion, release signing/upload, distribution, deployment or publication authorized by this draft.

@antuz123
antuz123 merged commit 0f18384 into codex/r5-cloud-integration-20261022 Oct 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants