Skip to content

ci: retain bounded product failure observations on reconciled diagnostics - #7119

Draft
antuz123 wants to merge 2 commits into
codex/r5-ios-diagnostic-reconciliation-20261022from
codex/r5-product-failure-reconciliation-20261022
Draft

antuz123 wants to merge 2 commits into
codex/r5-ios-diagnostic-reconciliation-20261022from
codex/r5-product-failure-reconciliation-20261022

Conversation

@antuz123

@antuz123 antuz123 commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

When a full-product first-wallet or Retry sample fails, its optional progress ACKs do not identify the failed action or cause. This separate Stage B preserves bounded JUnit, retained-hierarchy and current owned-Metro-window facts before private output is purged.

Head: 0f183841a1ed0aadf8874f15ccb1c889dd6c6515; branch codex/r5-product-failure-reconciliation-20261022.
Parents: frozen Stage A ba8c6958b214920a56c06ee78db8c87a40ebf237 and completed producer 1bc34890cb8618b2fffd446a63924974e0fe15b5.
Base: Stage A #7118, codex/r5-ios-diagnostic-reconciliation-20261022.

Patch-only Stage B review: 8 files, 940 additions / 7 deletions; 54,920 changed characters, approximately 13–17k source/test/doc tokens. One product-failure observation feature. Stage A remains independently reviewable.

Observation and reconciliation

  • The product coordinator binds the current owned Metro Popen, product phase/event count and regular log device/inode/EOF before the original Maestro command. On failure it reads only newly appended complete lines from that same binding. Earlier warmup/sample bytes, replaced/shrunk logs, malformed encoding/controls or another process cannot supply current-window facts.
  • JUnit accepts the pinned Maestro2.11 single-flow/testcase XML-text failure shape and exact fixed assertion/element first lines. The allowlist includes view_startNewTile and btn_skip. Unknown formats/messages remain ERROR_RECORDED or UNKNOWN without exporting text. Missing progress ACKs are never converted into a failed selector.
  • Hierarchy exports only fixed public flags, scoped to ANY_RETAINED_SNAPSHOT. It does not identify the final route, delivered tap, app ownership or current visibility. Invalid, duplicate-key, oversized, symlink and partial inputs cannot clear unseen UI; partial coverage retains null flags.
  • Observation/import failures preserve the original exception and existing cleanup. No extra native query, process, launch, installation, retry, Maestro action, timeout or Metro configuration is added. Private JUnit/hierarchy/screenshots/logs remain private and are purged by the existing lifecycle.
  • Stage A's hosted_native.py, startup_diagnosis.py, ios_startup_errors.py and startup_observer.cjs are byte-identical. No duplicate compact parser or legacy aliases return. The product helper, coordinator and new failure/lifecycle test file are byte-identical to producer1bc; overlap tests use the documented canonical categories and pure-module limits while retaining all privacy/negative assertions.

App source, dependencies, SDK/native inputs, workflows, UI/assertion flows, native command arguments/deadlines, scheduling and gates are unchanged.

Actual exact-head checks

Clean committed 0f18384:

  • 416 Node22.23.3 controls PASS, zero fail/cancel/skip/todo.
  • 265 Python controls PASS, no failures or skips, including actual failed-sample lifecycle/primary-error/purge controls and malformed/privacy/window-binding negatives.
  • Three native-workflow actionlint checks and whitespace: PASS.
  • Independent coordinator full source/helper/coordinator/docs/negative-control review and all 265 Python controls PASS; no concrete blocker.
  • Canonical Stage A implementation and the three unchanged producer files were independently byte-compared before freeze.

Receipt SHA256: f18b96a90f2e004e56089cb1281e26ef955d80bd188485d078c550948c05ba55. Logs and receipts are retained in the Cloud evidence workspace. Actual hosted origin push run39859947224 / job120107746484, attempt1: 285 Node tests PASS, zero failures/cancellations/skips/todos. Raw checkout and both before/final source receipts identify exact0f183 head; push workflow SHA equals that head. Raw log SHA256: f1422531508e2f3989587890e96ddead5c50b6fc7907e2875ad4fc3901a42a62. This is read-only origin-contract evidence; the full416 Node/265 Python results above were executed separately on the exact committed Cloud checkout. No producer or tree-equivalent pass is transferred.

The push server's inherited default-branch inventory remains199 dependency findings:3 critical,111 high,72 moderate,13 low. No dependency/security clearance is supplied here.

Original evidence and remaining acceptance

Producer #7116 remains unchanged at 1bc34890cb8618b2fffd446a63924974e0fe15b5; original producer patch. Its source/native receipts remain at that SHA. Its active serialized native run39858617273 is preserved; this draft adds no opt-in/label/job and does not cancel, duplicate or modify that window.

The older exact23f Android run passed startup, persistence, all five production workers and installed-byte checks, then failed product sample1. The recorded ACK prefix ends after Skip; the next start_new_visible ACK is absent. This does not establish a failed action, selector defect, UI state or cause. Its sole raw startup duration21652.183ms is not five complete startup/first-wallet pairs. Original failure/cleanup gaps remain recorded at their original source.

This package may capture better facts in a future failed sample; it supplies no app/selector fix, native iOS/Android pass, performance, physical, backend, installed trusted-gate or release acceptance. Recheck newer handoffs and active/result state before any future combined source freeze or native selection. Unidentified 5.2 remains excluded; 5.1 and 5.2 have not been tested together. No R5 candidate freeze.

Codex local handoff

State: NEEDS_LOCAL
PR: #7119
Base: codex/r5-ios-diagnostic-reconciliation-20261022
Head branch: codex/r5-product-failure-reconciliation-20261022
Head commit: 0f18384
Goal and acceptance criteria: Retain bounded fixed failed-product facts with exact current Metro ownership/window binding while preserving original failures, canonical startup truth and private cleanup.
Changes made: Separate eight-file Stage B; original producer ancestry and Stage A implementation preserved.
Cloud checks: Exact416 Node/265 Python/actionlint3/whitespace PASS; independent265 Python/full source review PASS. Hosted origin push39859947224/job120107746484 PASS285 Node with2 exact-source receipts; native iOS/Android on this head NOT RUN.
Required local checks: IOS, ANDROID
Local checks requested: Future independently reviewed combined hosted macOS/iOS→Android window after active producer completion; no new window selected by this draft. No personal Mac required.
Risks / known gaps: Product/startup causes UNKNOWN; source/host controls do not prove actual UI, physical devices, backend compatibility, installed trusted gate, security or release readiness.
Release readiness: NOT READY. No merge, shared promotion, release signing/upload, distribution, deployment or publication authorized by this draft.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants