Skip to content

ci: fix canonical native live-pin read identity - #7095

Draft
antuz123 wants to merge 288 commits into
sprintfrom
codex/r5-canonical-pin-read-identity
Draft

antuz123 wants to merge 288 commits into
sprintfrom
codex/r5-canonical-pin-read-identity

Conversation

@antuz123

Copy link
Copy Markdown
Collaborator

Canonical admission currently reads the driver variable with github-script's default GITHUB_TOKEN, which has no repository Variables permission. This follow-up keeps that client for Actions/checks/contents and requires a separate repository-selected Variables-read identity for every live pin check, including the collector's final recheck. Missing/denied/expired/revoked credentials and changed pins fail closed.

Follow-up to #7084 at 29a73faaf4312f3536db9aad1d5b6795042aef7d; the producer and #7085 branches are preserved. Base is sprint per AGENTS.md; inherited history is large. Review this bounded delta: 29a73fa...effd917

The sole secret is explicitly forwarded to the reusable worker and scoped to its initial provenance script. It is removed from the process environment before archive subprocesses; build/dependency tools receive no credential environment entry. Workflow permissions and serial native scheduling are unchanged. No snapshot/default-token fallback or release capability is added.

Verification: Node 22.23.3 node --test .github/tests/*.test.cjs with isolated locked compiler: 119 PASS; Python 3.12.14 infrastructure suite: 82 PASS; actionlint 1.7.12 on three canonical workflows: PASS (shellcheck/pyflakes integration disabled); whitespace PASS. Independent source review found no blocker; targeted controls 25 PASS on Node24.19.0.

Live read-only Variables probe returned 403 Resource not accessible by integration, X-Accepted-Github-Permissions: actions_variables=read. This was the current cloud integration, not an executed hosted GITHUB_TOKEN test; the default-client incompatibility is also verified from the pinned action and permission model. The dedicated credential is not provisioned/live-tested here. Installation handoff: CANONICAL-PIN-READ-INSTALLATION.md.

PREPARATION / NOT INSTALLED. No personal Mac, native dispatch, duplicate run, shared/producer branch update, sprint installation, protection/configuration change or release authorization. The incomplete parent acceptance matrix remains blocking.

Codex local handoff

State: NEEDS_LOCAL
Base: sprint
Head branch: codex/r5-canonical-pin-read-identity
Head commit: effd917
Goal and acceptance criteria: Installable read-only live Variables identity with no fallback; exact source/run/attempt and live revocation remain mandatory.
Changes made: Separate pin client, explicit step-only credential forwarding, focused positive/negative controls, installation inventory.
Cloud checks: Exact-head Node119/Python82/actionlint3/whitespace PASS; independent targeted25 PASS. Dedicated live-reader preflight NOT RUN; existing integration Variables GET403.
Required local checks: IOS, ANDROID
Local checks requested: Hosted canonical verification only after approved installation and independent API preflight; no personal Mac. This .github/docs patch is native-gate exempt, but installed route acceptance remains unverified.
Risks / known gaps: Unprovisioned Variables reader and finite expiry; secret replacement alone does not revoke a running token (revoke old PAT); incomplete parent matrix; legacy capacity admission is not atomic; native/physical/security acceptance and release approval remain separate.

Keep existing USDT wallets, Send, Receive, history, and backup routes. Remove new wallet creation and import entry points, plus buy, sell, and swap entry points. Leave the legacy GasFree Send implementation intact until a working replacement is verified.
Keep saved USDT wallets, receive addresses, chain reads, history, and backup recovery. Make Send show a pause message and warn before new deposits. Reject retired GasFree and swap credentials in release inputs and direct Android builds.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants