Skip to content

Superseded: Move USDT wallet creation to Settings - #7023

Closed
antuz123 wants to merge 6 commits into
sprintfrom
codex/r3-usdt-settings
Closed

antuz123 wants to merge 6 commits into
sprintfrom
codex/r3-usdt-settings

Conversation

@antuz123

@antuz123 antuz123 commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Superseded product direction (8 October 2026): New USDT activity is paused. Existing USDT wallets remain visible, and no new USDT wallet entry belongs in Settings. This PR must not merge as written; it is draft while the pause behavior is implemented.

Home Add Wallet opens the existing Bitcoin create/import/collaborative choices. USDT creation and import are under Settings > Keys & Wallets on the existing supported network (TESTNET in development, MAINNET in production). Existing USDT wallets retain Home access, send/receive, GasFree, backend and backup paths.

Updates the USDT, Settings and wallets OpenSpec requirements, and lets option copy wrap on narrow screens.

Validation

  • 10 focused component tests pass: network gate, Home choices, creation/import success and errors, retained wallets, send/receive and GasFree receive address.
  • Current signed arm64 iOS 2.6.3/619 Debug simulator: Home Bitcoin-only Add Wallet and actual Settings → creation form → back → empty seed import form → back pass on a disposable TESTNET app.
  • Native QA found and fixed the creation-form blank screen: frozen styles.link reached the text library, which tried to assign textDecorationLine. Both links now use the existing KeeperText array-copy path. Complete form renders with its risk note.
  • Added flows/usdt-settings-routes.yaml and setup instructions for reproducible route checks. It never submits a wallet, seed, send or backup request.
  • Current Android 2.6.3/626 development native shell with final JavaScript overlay: actual Settings → Create form → Back → empty seed import → Back and Bitcoin-only Home choices pass. A QA-only Firebase token bypass avoids an external token wait; no production source/network-policy change was made.
  • Current head 9a90b6f includes current public sprint 061f299 and has green Tests, Lint and CodeQL. Prettier/diff checks pass.
  • Copilot’s earlier implementation review has no inline findings. Fresh review is blocked by the requesting account’s quota; no new code review is claimed. Native evidence now covers both platforms.

Native evidence uses a local mocked Relay and no GasFree submission, funded transactions or physical-device claim. Existing-wallet send/receive preservation is focused component evidence.

Delivery targets sprint with shared mobile baseline #7031. One developer approval is required; product signoff is separate. Owner/human testing is retrospective after app release. This PR is not an app release.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation consistently relocates the entry point while preserving existing wallet and navigation behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Moves USDT wallet creation and import from Home to Settings while preserving existing USDT wallet behavior.

Changes:

  • Home Add Wallet now opens Bitcoin options directly.
  • Adds network-gated USDT create/import options under Settings.
  • Updates localization and OpenSpec requirements.
File Description
HomeWallet.tsx Removes USDT creation from Home.
USDTWalletCreationModal.tsx Adds reusable USDT create/import modal.
keeperSettings.tsx Adds network-gated USDT settings entry.
en.json Adds the USDT entry label.
es.json Adds the matching localization key.
wallets/​spec.md Documents unified wallet listing.
usdt/​spec.md Documents the relocated USDT flow.
settings/​spec.md Specifies the new settings entry point.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI balanced review requested due to automatic review settings October 7, 2026 12:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Native validation remains pending for wallet creation and import navigation flows.

Review effort: Balanced
Findings: None

Copilot AI balanced review requested due to automatic review settings October 7, 2026 13:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Native iOS and Android create/import routing validation remains incomplete for wallet-sensitive functionality.

Review effort: Balanced
Findings: None

Copilot AI balanced review requested due to automatic review settings October 7, 2026 13:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@antuz123
antuz123 marked this pull request as ready for review October 7, 2026 13:58
@antuz123
antuz123 marked this pull request as draft October 8, 2026 03:40
@antuz123 antuz123 changed the title Move USDT wallet creation to Settings Superseded: Move USDT wallet creation to Settings Oct 8, 2026
@antuz123 antuz123 closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants