Repository navigation
Conversation
`?CSV.File` and the API reference named no keywords, and `CSV.read` points to `CSV.File` for them. Add a grouped keyword list with defaults, and say which of them `CSV.lazy`, `CSV.Rows`, and `CSV.Chunks` reject. Drop "1.0" and "no longer" wording from the reading guide and the Chunks docstring. Fixes #1214. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 9 9
Lines 5569 5569
=======================================
Hits 5335 5335
Misses 234 234 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
?CSV.Fileand the API reference listed no keywords, andCSV.readpoints toCSV.Filefor them (#1214).CSV.Filedocstring: a grouped list of every keyword with its default, checked against the reader signatures and keyword tables insrc/api.jl.CSV.lazy,CSV.Rows,CSV.Chunks: one sentence each naming theCSV.Filekeywords they reject. A probe that passes each keyword to each reader confirmed the lists.Chunksdocstring: drop "in CSV.jl 1.0" and "no longer" wording.If #1210 merges first, the
select/dropentry should also mention the(i, name) -> Boolfunction.Fixes #1214.
🤖 Generated with Claude Code