Repository navigation
Conversation
Fix claims that did not match the code, and cut internals and change narration from the reading, writing, index, examples, migration, and release-notes pages and the public docstrings. Corrections, each checked with a probe on main and on CSV 0.10.16: - migration: 0.10 left date-times with more than three fraction digits as text instead of truncating them; 0.10 read `""` as missing; 0.10 inferred T/F as Bool and read 1/0 for types=Bool; 0.10 counted comment rows in footerskip; 0.10 Rows buffered only the current row; CSV.Chunks rejects maxwarnings; 0.10 already promoted Int and Float across sources. - writing: a partition base path "part.csv" writes "part.csv_1", ... - LazyFile: text cells follow stringtype, not always DataString. - 1.0 release notes: Rows typed access allocated until 1.1.0, and 0.10 did not truncate fractions. - The removed `debug` keyword message said "removed in 1.0" twice and both debug messages pointed at a non-public index; point at CSV.problems. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 9 9
Lines 5566 5566
=======================================
Hits 5332 5332
Misses 234 234 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pass over the manual pages, README, and public docstrings for accuracy and length.
Corrections (checked against main, and against CSV 0.10.16 for the migration guide):
typemap=Dict(Timestamp{Nanosecond} => DateTime), which keeps that behavior.""asmissing, 1.0 reads an empty string), the Boolean spellings 0.10 accepted (T/Finferred,1/0withtypes=Bool), andfooterskipno longer counting comment rows.CSV.Rowsbuffered one row; 1.0 keeps an index of every row (about 4 bytes per field plus 8 per row, measured).CSV.Chunksrejectsmaxwarnings. 0.10 already promotedInt/Floatacross sources; the change is that a missing column is filled instead of throwing."part.csv"writespart.csv_1,part.csv_2(as in 0.10); the example shows that now.CSV.LazyFile: text cells followstringtype.row.nameaccess did not allocate (fixed in 1.1.0) and the "no fraction digit is truncated" comparison.debugerror said "removed in 1.0" twice;debugandparsingdebugnow point atCSV.problems.Trims: implementation detail users don't act on (index geometry, scanner names, Int32 view offsets, lenient-rule mechanics, the Chunks pre-pass structure), change narration outside the migration guide and release notes, and repeated statements.
CSV.write's docstring lists its keywords with defaults, like #1215 does forCSV.File. Jacob's original example comments are unchanged.Overlap: no hunk overlaps #1210, #1212, #1213, #1215, or #1216;
git merge-treemerges this branch cleanly with each. The tails of theCSV.lazyandCSV.Chunksdocstrings still carry internals (view offsets, pre-pass details); I left them because #1215 edits those lines.Verification:
julia --project=docs docs/make.jlbuilds with doctests and no warnings; the full suite passes locally (331,778 tests, Julia 1.12.6,--check-bounds=yes -t4). Each changed claim was checked with a probe.🤖 Generated with Claude Code