Skip to content

refactor: Use ChunkCodecLibLzma for XZ compression + set default size params for all codecs #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icweaver merged 3 commits into from
Aug 27, 2026
Merged

refactor: Use ChunkCodecLibLzma for XZ compression + set default size params for all codecs #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a4e549
Use ChunkCodecLibLzma for XZ compression
nhz2 Aug 25, 2026
22d2b54
docs fix
nhz2 Aug 25, 2026
e862e3a
fix formatting
nhz2 Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
ChunkCodecLibBlosc = "c6a955be-ab7f-4fbb-b38f-caf93db6b928"
ChunkCodecLibBzip2 = "2b723af9-f480-4e8d-a1e4-4a9f5a906122"
ChunkCodecLibLz4 = "7e9cc85e-5614-42a3-ad86-b78f920b38a5"
ChunkCodecLibLzma = "e95d29e5-19c5-4afd-ae0f-beb790efacdf"
ChunkCodecLibZlib = "4c0bbee4-addc-4d73-81a0-b6caacae83c8"
ChunkCodecLibZstd = "55437552-ac27-4d47-9aa3-63184e8fd398"
CodecXz = "ba30903b-d9e8-5048-a5ec-d1f5b0d4b47b"
FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
MD5 = "6ac74813-4b46-53a4-afec-0b5dc9d7885c"
OrderedCollections = "bac558e1-5e72-5ebc-8fee-abe8a469f55d"
Expand All @@ -26,9 +26,9 @@ AbstractTrees = "0.4.5"
ChunkCodecLibBlosc = "0.2.0, 0.3"
ChunkCodecLibBzip2 = "0.2.0, 1.0"
ChunkCodecLibLz4 = "0.2.1, 1.0"
ChunkCodecLibLzma = "1.0"
ChunkCodecLibZlib = "0.2.0, 1.0"
ChunkCodecLibZstd = "0.2.0, 1.0"
CodecXz = "0.7.4"
FileIO = "1"
MD5 = "0.2.1"
OrderedCollections = "1.8.1, 2"
Expand Down
18 changes: 8 additions & 10 deletions src/ASDF.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ module ASDF
using ChunkCodecLibBlosc: BloscCodec, BloscEncodeOptions
using ChunkCodecLibBzip2: BZ2Codec, BZ2EncodeOptions
using ChunkCodecLibLz4: LZ4BlockCodec, LZ4FrameCodec, LZ4BlockEncodeOptions, LZ4FrameEncodeOptions
using ChunkCodecLibLzma: XZCodec, XZEncodeOptions
using ChunkCodecLibZlib: ZlibCodec, ZlibEncodeOptions
using ChunkCodecLibZstd: ZstdCodec, ZstdEncodeOptions, decode, encode
using CodecXz: XzCompressor, XzDecompressor
using MD5: md5
using PkgVersion: PkgVersion
using StridedViews: StridedView
Expand Down Expand Up @@ -36,7 +36,7 @@ Identifies the compression algorithm used for a data block. Available variants:
| `C_Bzip2` | `bzp2` | ChunkCodecLibBzip2.jl | Good ratio, moderate speed (default) |
| `C_Lz4` (:block) | `lz4\\0` | ChunkCodecLibLz4.jl | Fastest decompression, Python-compatible |
| `C_Lz4` (:frame) | `lz4\\0` | ChunkCodecLibLz4.jl | LZ4 frame format for non-Python consumers |
| `C_Xz` | `xz\\0\\0` | CodecXz.jl | Highest compression ratio, slowest |
| `C_Xz` | `xz\\0\\0` | ChunkCodecLibLzma.jl | Highest compression ratio, slowest |
| `C_Zlib` | `zlib` | ChunkCodecLibZlib.jl | Broad compatibility |
| `C_Zstd` | `zstd` | ChunkCodecLibZstd.jl | Best ratio/speed trade-off |
"""
Expand Down Expand Up @@ -282,23 +282,24 @@ function read_block(header::BlockHeader)
compression = compression_enums[header.compression]
if compression == C_None
# do nothing, the block is uncompressed
elseif compression == C_Xz
data = transcode(XzDecompressor, data)
elseif compression == C_Lz4
data = decode_Lz4(data)
else
if compression == C_Blosc
codec = BloscCodec()
elseif compression == C_Bzip2
codec = BZ2Codec()
elseif compression == C_Xz
codec = XZCodec()
elseif compression == C_Zlib
codec = ZlibCodec()
elseif compression == C_Zstd
codec = ZstdCodec()
else
error("Invalid compression format found: $compression")
end
data = decode(codec, data)
d_size = Int64(header.data_size)
data = decode(codec, data; max_size = d_size, size_hint = d_size)
end
data::AbstractVector{UInt8}

Expand Down Expand Up @@ -1835,11 +1836,6 @@ function write_file(filename::AbstractString, document::AbstractDict)
# TODO: Write directly to file
if array.compression == C_None
data = input
elseif array.compression == C_Xz
# Copy
# TODO: Don't copy input
input = input isa Vector ? input : Vector(input)
data = transcode(XzCompressor, input)
elseif array.compression == C_Lz4 && array.lz4_layout == :block
data = encode_Lz4_block(input)
#data = encode(LZ4BlockEncodeOptions(), input) # Not compatible with Python asdf
Expand All @@ -1850,6 +1846,8 @@ function write_file(filename::AbstractString, document::AbstractDict)
encode_options = BZ2EncodeOptions(; blockSize100k = 9)
elseif array.compression == C_Lz4 && array.lz4_layout == :frame
encode_options = LZ4FrameEncodeOptions(; compressionLevel = 12, blockSizeID = 7)
elseif array.compression == C_Xz
encode_options = XZEncodeOptions(; preset = UInt32(6))
elseif array.compression == C_Zlib
encode_options = ZlibEncodeOptions(; level = 9)
elseif array.compression == C_Zstd
Expand Down
Loading