Repository navigation
refactor: Use ChunkCodecLibLzma for XZ compression + set default size params for all codecs - #71
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 589 589
=========================================
Hits 589 589 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
This looks great, thanks Nathan. Also, cool, I see you're at UMD. I was raised in the area, Go Terps! |
icweaver
referenced
this pull request
Sep 19, 2026
I need a release so that #68 is incorporated in a publicly installable version for collaborators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChunkCodecLibLzma has a stable API now, allows setting a preset (this is what liblzma calls compression level), and removes the extra copy when compressing.
I have the preset at the default of
UInt32(6), but this can be increased toUInt32(9)for more compression.Also, since the decompressed size is already known, I'm passing it as a
max_sizeandsize_hinttodecodefor better memory usage.