Skip to content

Consolidate the five new_* cookiecutter functions (WP6) - #23

Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin/wp5-target-parsing-gcovrfrom
devin/wp6-cookiecutter-consolidation
Closed

devin-ai-integration[bot] wants to merge 1 commit into
devin/wp5-target-parsing-gcovrfrom
devin/wp6-cookiecutter-consolidation

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Related Issue(s)
Has Unit Tests (y/n) y
Documentation Included (y/n) n

Change Description

  • util/cookiecutter_wrapper.py: one private _new_from_template(...) doing settings-override resolution, the cookiecutter(...) call, a uniform try/except, and register_with_cmake; the five public new_* functions become thin wrappers — names and signatures unchanged.
  • Bug fixes that fall out: --overwrite now honored by new --component (only that call omitted overwrite_if_exists); misleading "Permission denied" message on FileNotFoundError corrected; uniform exception coverage across all five kinds.
  • is_valid_name: isinstance check hoisted above the per-character loop; name, module path, and "valid" return contract unchanged (shipped hooks depend on it).

Rationale

WP6 of 9, stacked on #21. Per-kind error strings preserved byte-for-byte except the misleading text above; net −80 LOC of duplication.

Testing/Review Recommendations

New per-kind instantiation tests plus an --overwrite regression test; suite 172 passed; black clean. Minor behavior notes: component's OSError message now goes to stderr (text unchanged); --overwrite behavior change is the bug fix.

Future Work

WP7–WP9 of the series.

Pushed by Devin AI

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/bba39c1277854bf8a1fd63a094f20e24
Requested by: @thomas-bc-autobot


Open in Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Author
Original prompt from thomas.boyer.chammard

I want this session to be a large effort to make fprime-tools more maintainable and cleaner code/less technical debt. Please make a plan to study that and deliver a master plan. Allocate subagent to find areas that can be improved, then more subagents to study it in detail and make a plan, then iterate on the plan with other review agents until the review agent and planner agent agree on an approved plan. Once the approved plan is done, have other implementer agents implement the plan, and review agents that build and test the result. Iterate until everyone agrees the code is correct and an improvement. Use subagents, high importance goals:

  • CLI and external APIs should ideally be left unchanged, or backwards compatibility layer left in
  • The less line of code changes, the easier the review. But if lots of LOC for high value simplification, it is ok.

Let’s go! Don’t stop, keep iterating until my goals are met.

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

…(WP6)

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/wp5-target-parsing-gcovr branch from 7f4c115 to 06740c9 Compare August 28, 2026 16:31
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/wp6-cookiecutter-consolidation branch from 8696b91 to 3f7ddca Compare August 28, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant