Repository navigation
Harden CLI, fbuild, and import-compatibility test coverage (WP7) - #24
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Original prompt from thomas.boyer.chammard
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Delete test/fprime/util/commands_unit_test.py: 12 empty tests (bodies were literally 'pass'), inflating the reported count. Collected test count drops accordingly before rising with the additions below. - Add test/fprime/util/test_util_cli.py: parse_args coverage for every command (namespace, -D handling, --jobs extraction, unknown-arg rejection) and utility_entry dispatch tests with mocked load_build. - Add test/fprime/fbuild/test_fbuild_mocked.py: mocked-subprocess tests for the 'No rule to make target' auto-refresh retry, Gcovr argv assembly, and purge force/confirm/missing-dir logic. - Add test/fprime/test_import_compat.py: import-compatibility test asserting the specific symbols consumers use across all public module paths (module identity assertions deferred to WP8). Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
8696b91 to
3f7ddca
Compare
4a7abbb to
6375fe7
Compare
Change Description
Test-only PR; no
src/changes.test/fprime/util/commands_unit_test.py(12 empty test bodies that only inflated counts).test/fprime/util/test_util_cli.py:parse_args/dispatch coverage for the CLI surface (namedtest_util_cli.pybecause pytest rejects a secondtest_cli.pybasename alongsidetest/fprime/fpp/test_cli.py).IniSettings,Build,BuildType,is_valid_name,Target,FppUtility,U32Type) resolve from all old module paths in the WP8 mapping table — this is the safety net that must stay green through the WP8 reorganization. Thefprime.common.models.serialize.*cases skip whenfprime_gdsis not installed (those shims re-export from it).Rationale
WP7 of 9, stacked on #23. Locks in current behavior before WP8 moves modules.
Testing/Review Recommendations
221 passed + 9 skipped (vs 172 on base; the 9 skips are the fprime_gds-dependent cases); black clean.
Future Work
WP8 module reorganization, WP9 fpp_to_json disposition.
Pushed by Devin AI
Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/bba39c1277854bf8a1fd63a094f20e24
Requested by: @thomas-bc-autobot