Repository navigation
Harden target-list parsing and unify gcovr project-root fallback (WP5) - #21
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Original prompt from thomas.boyer.chammard
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…WP5) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
071f835 to
0f693d8
Compare
7f4c115 to
06740c9
Compare
Change Description
cmake.pyget_available_targets: guard emptycmake --build ... helpoutput (was an unguardedstdout[0]→IndexError); detect the generator from theCMAKE_GENERATORcache variable instead of sniffing the first help line;startswith+ slice instead ofmake.replace(prefix, "")(which mangles targets containing the prefix twice); clearcached_help_targetsincmake_refresh_cache.gcovr.py: single_get_project_roothelper with one documented fallback (build_dir.parent) — previously_get_project_pathandexecutedisagreed (parentvsparent.parent) for the same value;framework_pathresolved consistently.Rationale
Fragile-parsing fixes exercised by the make+ninja integration matrix (WP5 of 9, stacked on #20). The gcovr change only affects the no-settings fallback path, where at most one of the two previous fallbacks could have been right.
Testing/Review Recommendations
New parsing tests with canned ninja/make help output. Suite: 165 passed; black clean. Review focus: the gcovr fallback unification is an intentional behavior change on a buggy path.
Future Work
WP6–WP9 of the series.
Pushed by Devin AI
Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/bba39c1277854bf8a1fd63a094f20e24
Requested by: @thomas-bc-autobot