Repository navigation
Retain closed KV failure diagnostics without retry - #281
Conversation
Project only allowlisted worker/transport reason codes, bounded transport invocation counts and outer execution fields from fixed trusted paths. Missing outcomes remain unavailable, not zero; slots or invocations never prove HTTP delivery or billing. Preserve failure behavior, reservations and no-retry policy. Source-equivalent to independently reviewed local 66a39a82da7743a0dafe35b825dc123635f1eb72. Validation: 196 affected offline tests, 20 worker checks after import cleanup, 34 independent focused checks, whole-tree Ruff and diff checks passed. Does not recover the earlier run cause or authorize another paid attempt. Agent-assisted-by: Codex / gpt-6-astra [effort=xhigh] Signed-off-by: Codex <codex@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Dong1017
left a comment
There was a problem hiding this comment.
Scoped software LGTM: no blocking source findings for head a8ab81ad30355f69a87ff4344dbb9bda3b2f313d, against main 3ece458ceaa92c5dad8d8e0b1e782a6961400b96.
I independently matched the remote tree 48086800b28f04a4f5a98329f56a596cdc2ba88f and all five changed blobs to previously reviewed local 66a39a82 (+214/-5). There is no new integration-code delta. My 34 focused offline tests on those identical bytes are reused, not represented as a new full-suite run.
The correction retains only closed reason/error codes, bounded transport-invocation counts and executor status/return code/elapsed time from fixed trusted files. Arbitrary exception/provider text is excluded. Recorded zero remains distinct from unavailable null; the gate-rejection control demonstrates that a consumed slot can coexist with zero transport invocations. Unknown usage still stops the next arm and retains the full reservation; no retry/refund, oracle, timing or credential-scope change is introduced. Packaging only reads existing outputs and cannot turn diagnostic availability into an experimental PASS.
CI remains pending: replacement Ready 41163947370 is pending at this read; superseded-run cancellations are not passes or source failures. Declarations and Draft checks passed. Native review is still running. This source conclusion does not replace applicable current-head CI; the existing author is monitoring it.
The first run's missing cause, delivery and billing remain unknown. These changed source identities deliberately do not satisfy the expired old freeze, and this review authorizes no new paid attempt. COMMENTED only: no formal approval, merge, model/hardware execution or ledger change.
Preserve closed failure diagnostics
Refs #248; follow-up to #280. This five-file software-only correction preserves evidence for future failures without changing the paid execution policy.
null). Neither consumed slots nor transport invocation counts establish HTTP delivery, billing or success.This does not recover the first run's cause. Run 41159550621 retained one consumed A2 slot with unknown completion/usage; that does not prove per-request authorization succeeded or HTTP was sent. A3 did not start, and both grades are INCONCLUSIVE. The existing $162.72 reservation remains retained; actual billing is unknown. Its execution window has expired. This PR does not authorize or perform another paid attempt, alter that freeze, or replace original evidence.
Reviewed source and verification
Published head
a8ab81ad30355f69a87ff4344dbb9bda3b2f313dpreserves independently reviewed local commit66a39a82da7743a0dafe35b825dc123635f1eb72, tree48086800b28f04a4f5a98329f56a596cdc2ba88f. Current main is unchanged from the reviewed base: exactly five files, +214/-5. Changed worker/controller bytes intentionally cannot match the old frozen source identities.send_messagewith mock HTTP 401/429/5xx, invalid JSON, credential echo, network errors, arbitrary-text canaries, malformed/missing results and slot consumption followed by gate rejection with zero transport invocations.Authorship
Actual implementation and independent review: Codex / gpt-6-astra / xhigh. The API publication wrapper preserves the locally tested source tree; source review, CI and operational authorization remain distinct.