Repository navigation
Give ComfyUI-Manager's legacy windows a background on frontend 1.57+ - #21
Merged
Merged
Conversation
Frontend 1.57 stopped loading PrimeVue's dialog styles. ComfyUI-Manager's legacy windows (Git Manager 3.39+, pip comfyui-manager up to 4.3) are built from PrimeVue dialog class names, so they lost their background, border and header layout. Repeat PrimeVue's own dialog rules for just those four windows, using PrimeVue's variables with its defaults as fallbacks, so frontends that still load PrimeVue's styles render exactly as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On images with ComfyUI frontend 1.57+ (for example ComfyUI-Minimal v0.43, frontend 1.57.4), the ComfyUI-Manager windows have no background: the buttons float over the canvas. Stacked windows overlap and become unreadable.
Cause: frontend change
ComfyUI_frontend #16352(first shipped in 1.57.1) replaced the PrimeVue Dialog, so the frontend no longer loads PrimeVue's dialog styles. The Manager's legacy windows are hand-built from PrimeVue class names (p-dialog,p-dialog-header,p-dialog-content), so they lost their background, border and header layout. This affects Git Manager 3.39+ (3.38 and earlier use a different dialog) and pipcomfyui-managerup to 4.3, on both the Git and the pip Manager.ComfyUI-Manager #3392fixed it on the Manager'smain, andComfyUI-Manager #3457backports it to the pip line. Neither has been released yet.Change
One new file,
web/manager-dialog.js, which adds one<style>.#cm-manager-dialog,#cn-manager-dialog,#cmm-manager-dialogand#snapshot-manager-dialog. They also have to carry.p-dialog.--p-dialog-background,--p-dialog-header-padding, …). The fallback is PrimeVue's default or the ComfyUI palette color. On a frontend that still loads PrimeVue's styles the result is identical to before. On 1.57+ the fallbacks apply.:where(), so any other rule on these elements wins.#3392/#3457usecm-ui-dialoginstead of.p-dialog, so the rules don't match them.Nothing else on the page is touched: no buttons, inputs or other dialogs.
Verified
Local ComfyUI, Chromium. Each check opened the four windows, then compared the computed styles of the window, header and content with this style on and off.
rgba(0,0,0,0)→rgb(23,23,24), with border and rounded corners. The close button is back on the right.#3457Not run on int yet. int machines check out
developon start and prod machines usemain, so this reaches int once it merges intodevelop, and prod after thedevelop→mainrelease.🤖 Generated with Claude Code