Skip to content

Give ComfyUI-Manager's legacy windows a background on frontend 1.57+ - #21

Merged
loner233 merged 1 commit into
developfrom
jack-claude/manager-dialog-styles
Nov 3, 2026
Merged

loner233 merged 1 commit into
developfrom
jack-claude/manager-dialog-styles

Conversation

@loner233

@loner233 loner233 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

On images with ComfyUI frontend 1.57+ (for example ComfyUI-Minimal v0.43, frontend 1.57.4), the ComfyUI-Manager windows have no background: the buttons float over the canvas. Stacked windows overlap and become unreadable.

Cause: frontend change ComfyUI_frontend #16352 (first shipped in 1.57.1) replaced the PrimeVue Dialog, so the frontend no longer loads PrimeVue's dialog styles. The Manager's legacy windows are hand-built from PrimeVue class names (p-dialog, p-dialog-header, p-dialog-content), so they lost their background, border and header layout. This affects Git Manager 3.39+ (3.38 and earlier use a different dialog) and pip comfyui-manager up to 4.3, on both the Git and the pip Manager. ComfyUI-Manager #3392 fixed it on the Manager's main, and ComfyUI-Manager #3457 backports it to the pip line. Neither has been released yet.

Change

One new file, web/manager-dialog.js, which adds one <style>.

  • Which windows: only the Manager's four legacy windows, matched by id: #cm-manager-dialog, #cn-manager-dialog, #cmm-manager-dialog and #snapshot-manager-dialog. They also have to carry .p-dialog.
  • What it sets: the same properties PrimeVue's own dialog rules set. The window gets background, border and border-radius, the header is a flex row with the close button on the right, and both the header and the content get padding.
  • Values: each value uses PrimeVue's own variable (--p-dialog-background, --p-dialog-header-padding, …). The fallback is PrimeVue's default or the ComfyUI palette color. On a frontend that still loads PrimeVue's styles the result is identical to before. On 1.57+ the fallbacks apply.
  • Specificity: the rules are wrapped in :where(), so any other rule on these elements wins.
  • Fixed Manager versions: versions with #3392 / #3457 use cm-ui-dialog instead of .p-dialog, so the rules don't match them.

Nothing else on the page is touched: no buttons, inputs or other dialogs.

Verified

Local ComfyUI, Chromium. Each check opened the four windows, then compared the computed styles of the window, header and content with this style on and off.

Frontend Manager Result
1.57.4 pip 4.2.2 (what v0.43 ships) All four windows: background rgba(0,0,0,0) → rgb(23,23,24), with border and rounded corners. The close button is back on the right.
1.57.4 Git 3.41 Same fix on all four windows.
1.57.4 pip 4.3 + #3457 0 differences.
1.48.7 pip 4.2.2 0 differences.
1.48.7 Git 3.41 0 differences.
1.48.7 Git 3.42 on core v0.3.76 0 differences.

Not run on int yet. int machines check out develop on start and prod machines use main, so this reaches int once it merges into develop, and prod after the develop → main release.

🤖 Generated with Claude Code

Frontend 1.57 stopped loading PrimeVue's dialog styles. ComfyUI-Manager's
legacy windows (Git Manager 3.39+, pip comfyui-manager up to 4.3) are built
from PrimeVue dialog class names, so they lost their background, border and
header layout. Repeat PrimeVue's own dialog rules for just those four
windows, using PrimeVue's variables with its defaults as fallbacks, so
frontends that still load PrimeVue's styles render exactly as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T13:55:53.139982Z 1912068 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant