Repository navigation
Conversation
Frontend 1.57 stopped loading PrimeVue's dialog styles. ComfyUI-Manager's legacy windows (Git Manager 3.39+, pip comfyui-manager up to 4.3) are built from PrimeVue dialog class names, so they lost their background, border and header layout. Repeat PrimeVue's own dialog rules for just those four windows, using PrimeVue's variables with its defaults as fallbacks, so frontends that still load PrimeVue's styles render exactly as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tyles Give ComfyUI-Manager's legacy windows a background on frontend 1.57+
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases #21 to main. Only
web/manager-dialog.jsis added.On images with ComfyUI frontend 1.57+ (for example ComfyUI-Minimal v0.43), the ComfyUI-Manager windows have no background, so they overlap the canvas and each other. Frontend 1.57 stopped loading PrimeVue's dialog styles, and the Manager's legacy windows are built from PrimeVue class names. The helper now adds PrimeVue's own dialog rules back for just the Manager's four windows. On frontends that still load PrimeVue's styles, the windows render exactly as before. Details in #21.
Tested
main, pip 4.0.3b4 to 4.3):develop):rgba(0, 0, 0, 0)torgb(23, 23, 24), with a 1px border, 12px corners, and the close button on the right.develop):Prod machines pick this up on their next start.
🤖 Generated with Claude Code