Skip to content

Give ComfyUI-Manager's legacy windows a background on frontend 1.57+ (develop -> main) - #22

Merged
loner233 merged 2 commits into
mainfrom
develop
Nov 3, 2026
Merged

loner233 merged 2 commits into
mainfrom
develop

Conversation

@loner233

@loner233 loner233 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Releases #21 to main. Only web/manager-dialog.js is added.

On images with ComfyUI frontend 1.57+ (for example ComfyUI-Minimal v0.43), the ComfyUI-Manager windows have no background, so they overlap the canvas and each other. Frontend 1.57 stopped loading PrimeVue's dialog styles, and the Manager's legacy windows are built from PrimeVue class names. The helper now adds PrimeVue's own dialog rules back for just the Manager's four windows. On frontends that still load PrimeVue's styles, the windows render exactly as before. Details in #21.

Tested

  • Locally, 19 combinations of ComfyUI core (v0.3.39 to v0.43.0), frontend (1.20.7 to 1.58.4) and Manager (Git 3.38 to the latest main, pip 4.0.3b4 to 4.3):
    • The 5 combinations on frontend 1.57.1+ whose Manager windows are built from PrimeVue class names are fixed.
    • The other 14 show no computed-style difference on any element.
    • In all 19, no element outside the four windows changed.
  • int, ComfyUI-Minimal v0.43.0 (frontend 1.57.4, pip Manager 4.2.2 with the legacy UI, helper from develop):
    • All four windows are fixed. Background goes from rgba(0, 0, 0, 0) to rgb(23, 23, 24), with a 1px border, 12px corners, and the close button on the right.
    • 84 elements inside the windows changed and 0 of the other 1,546 did.
    • All four close buttons work.
  • int, Flux_32k_Upscaler_update (an older image: ComfyUI 0.3.39, frontend 1.20.7, no Manager installed, helper from develop):
    • The style loads but matches nothing. 0 of 476 elements changed.
    • That count includes the frontend's own Missing Node Types dialog, which is a PrimeVue dialog and was open during the check.

Prod machines pick this up on their next start.

🤖 Generated with Claude Code

loner233 and others added 2 commits November 2, 2026 21:53
Frontend 1.57 stopped loading PrimeVue's dialog styles. ComfyUI-Manager's
legacy windows (Git Manager 3.39+, pip comfyui-manager up to 4.3) are built
from PrimeVue dialog class names, so they lost their background, border and
header layout. Repeat PrimeVue's own dialog rules for just those four
windows, using PrimeVue's variables with its defaults as fallbacks, so
frontends that still load PrimeVue's styles render exactly as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tyles

Give ComfyUI-Manager's legacy windows a background on frontend 1.57+
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T02:37:39.746828Z 6b60e89 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@loner233
loner233 merged commit b4b41e3 into main Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant