Skip to content

fix: apply the Chrome parrot spec in Start, after the transport parameters #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ari-ahm wants to merge 1 commit into
base: v0.63.0-mod-rename
Choose a base branch
from
Open

fix: apply the Chrome parrot spec in Start, after the transport parameters #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions internal/handshake/tls_conn_utls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ func newUTLSQUICClient(tlsConf *tls.Config) (*utlsQUICConn, error) {
spec := chromeQUICClientHelloSpec(tlsConf.NextProtos)

conn := utls.UQUICClient(&utls.QUICConfig{TLSConfig: uConf}, utls.HelloCustom)
if err := conn.ApplyPreset(spec); err != nil {
return nil, fmt.Errorf("applying Chrome ClientHello spec: %w", err)
}
// The spec is applied in Start, after SetTransportParameters has written the
// transport parameters into it: newer uTLS versions deep-copy the spec in
// ApplyPreset, so changes made to it afterwards would never reach the ClientHello.
return &utlsQUICConn{conn: conn, spec: spec}, nil
}

Expand Down Expand Up @@ -118,8 +118,13 @@ func signatureSchemesToStd(in []utls.SignatureScheme) []tls.SignatureScheme {
return out
}

func (c *utlsQUICConn) Start(ctx context.Context) error { return c.conn.Start(ctx) }
func (c *utlsQUICConn) Close() error { return c.conn.Close() }
func (c *utlsQUICConn) Start(ctx context.Context) error {
if err := c.conn.ApplyPreset(c.spec); err != nil {
return fmt.Errorf("applying Chrome ClientHello spec: %w", err)
}
return c.conn.Start(ctx)
}
func (c *utlsQUICConn) Close() error { return c.conn.Close() }

func (c *utlsQUICConn) HandleData(level tls.QUICEncryptionLevel, data []byte) error {
return c.conn.HandleData(utlsEncryptionLevel(level), data)
Expand Down