Repository navigation
Conversation
…eters SetTransportParameters writes quic-go's transport parameters into the retained ClientHello spec, but the spec was applied in newUTLSQUICClient, before that call. That works with uTLS v1.8.2, whose ApplyPreset keeps the caller's extension objects. Newer uTLS (master since ff1b50fbbe9a) deep-copies the spec in ApplyPreset, so the parameters never reach the ClientHello and every handshake fails with "missing initial_source_connection_id". Applying the spec in Start works with both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KqYot5fp6kvHireReN6Lu7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetTransportParameterswrites quic-go's transport parameters into the retained ClientHello spec (c.spec), butnewUTLSQUICClientapplied that spec withApplyPresetbeforeSetTransportParametersis called (NewCryptoSetupClient). That works with the uTLS this branch pins (v1.8.2), whoseApplyPresetkeeps the caller's extension objects.uTLS master (since
ff1b50fbbe9a, 2026-10-06) deep-copies the spec inApplyPreset. With it, the transport parameters never reach the ClientHello and every Chrome-parrot handshake fails:This applies the spec in
Startinstead, once the parameters are in it. It's a no-op change with v1.8.2 and fixes newer uTLS.Tests
integrationtests/selfChrome parrot tests (-run ChromeParrot):ff1b50fbbe9a+ refraction-networking/utls#424TestChromeParrotHandshakefails as aboveinternal/handshakepasses, and both pass with-race -count=3.Not included: bumping uTLS
When this branch bumps uTLS, two more things are needed:
UQUICConn.Closecan deadlock mid-handshake (UQUICConn.Close() deadlocks: missing the<-signalcreceive that QUICConn.Close() has refraction-networking/utls#421). Fix UQUICConn.Close deadlock and report handshake errors in NextEvent refraction-networking/utls#424 fixes it; I'd wait for it before bumping.QUICErrorEvent, whichutlsQUICConn.NextEventdoesn't map, so it would hit the "unexpected uTLS QUIC event kind" panic. It needscase utls.QUICErrorEvent:returningtls.QUICEvent{Kind: tls.QUICErrorEvent, Err: ev.Err}(via the go1.25/go1.26 files, since crypto/tls only has it from Go 1.26). It can't go in now because v1.8.2 doesn't haveutls.QUICErrorEvent.Found while bumping uTLS in Xray-core, which uses this branch through its v0.61.0 version.
🤖 Generated with Claude Code