Skip to content

chore: housekeeping — stale requirements files, roadmap corrections, medical template row - #996

Merged
cemililik merged 8 commits into
developmentfrom
consolidated/housekeeping
Oct 18, 2026
Merged

cemililik merged 8 commits into
developmentfrom
consolidated/housekeeping

Conversation

@cemililik

@cemililik cemililik commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Three small, already-reviewed fixes combined into one pull request, replacing #979, #980 and #981 (which will be closed as superseded). Each was green on its own and the bot findings on #980 and #981 are already folded in.

Related issues

Fixes #968. Refs #91, #75, #97.

Changes

Was What it does
#979 Deletes the stale requirements.txt, requirements-eval.txt and requirements-linux.txt. Nothing referenced them, their floors were far below pyproject.toml's, and Dependabot would have opened weekly PRs against them. Merging this before Monday 2026-10-19 avoids those PRs.
#980 Roadmap/strategy corrections: forgelm chat does not screen for safety and reads no YAML (#91); live risk rows no longer name a past "August 2026" deadline and now limit the dates to Chapter III Sections 1–3 as CodeRabbit asked (#75); docs/product_strategy.md (EN+TR) names the real evaluation.auto_revert field.
#981 The medical-qa-tr row of the YAML templates reference (EN+TR): the template enables no safety evaluation and has no risk_assessment metadata; it is not for clinical decision support, and the row says to set evaluation.safety.enabled: true and fill in risk_assessment accurately (Sourcery and CodeRabbit findings applied).

Type

  • Documentation
  • Chore

Testing

  • The full CLAUDE.md gauntlet from a clean worktree of this branch: exit 0.

Checklist

  • English and Turkish mirrors updated together
  • CHANGELOG entries under [Unreleased]

🤖 Generated with Claude Code

Summary by Sourcery

Remove stale dependency files and correct safety, compliance, and medical-template documentation across the project.

Bug Fixes:

  • Correct roadmap, risk, and strategy documentation to accurately describe chat safety behavior, EU AI Act timelines, and the current evaluation auto-revert configuration.
  • Clarify the medical QA template’s safety limitations and required evaluation and risk-assessment settings in English and Turkish references.

Enhancements:

  • Remove the obsolete requirements files and direct installation guidance through pyproject.toml extras.

Documentation:

  • Update the English and Turkish documentation mirrors and record the housekeeping and documentation corrections in the unreleased changelog.

cemililik and others added 8 commits October 18, 2026 02:27
Three requirements files sat at the repository root and nothing used them: the Dockerfile, the
workflows, the tests and the documentation all install through the pyproject.toml extras. Their
floors were far below pyproject's (torch>=2.0.0 against >=2.4.0, transformers>=4.38.0 against
>=5.3.0), and Dependabot, which scans requirements*.txt, would have opened weekly pull requests
against them from its first run.

Also removes the note in .github/dependabot.yml that said they should be deleted when this cleanup
landed, and the requirements*.txt line in .dockerignore, which no longer matches anything. The
requirements.lock comment in pyproject.toml and its decision row in docs/roadmap/risks-and-decisions.md
are about a future lock file, not these three, and stay as they are.

Fixes #968

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e rows and a non-existent config field

- completed-phases.md: `forgelm chat` performs no safety screening and reads no YAML config, so the
  sentence that said operators get "the same screening" through `safety: enabled: true` was false; it now says
  so and points at `forgelm safety-eval --model <path> --default-probes`. A note at the top of the archive
  says its "August 2026 full enforcement" wording is the planning assumption of the time, not the current
  position (#91, #75).
- risks-and-decisions.md: the three live rows that named an "August 2026" deadline now give the two
  application dates the strategy document already uses.
- product_strategy.md and its Turkish mirror: the config field is `evaluation.auto_revert`, not
  `auto_revert_on_safety_failure`, and what it does is stated (it deletes the trained artefacts and the run
  exits 3).

The decision record (the GTM row) is left as written: it is history.

Refs #91, #75

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The templates reference (English and Turkish) said medical-qa-tr "ships with risk_assessment + safety eval
pre-wired". The template's config has no `evaluation` and no `risk_assessment` block; only the sample answers
carry a safety disclaimer. A user starting from a template in a regulated domain would have believed a gate was
on. The row now says what is and is not enabled and what to add before any use beyond a demo.

Refs #97

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Review finding: Regulation (EU) 2026/1744 delays Chapter III, Sections 1-3 (except Article 6(5)), to 2 December 2027 for Annex III
systems and 2 August 2028 for Annex I systems. The risk row said 'high-risk obligations', which is wider.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…clinical use

Review findings on the medical-qa-tr row: adding the two blocks does not make the template suitable for clinical decision support,
and an evaluation.safety block without enabled: true leaves the check off. The row now says the template is not for clinical decision
support, to set evaluation.safety.enabled: true, and to fill in the risk_assessment block accurately. English and Turkish.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
# Conflicts:
#	CHANGELOG.md
@sourcery-ai

sourcery-ai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Sorry @cemililik, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 12 hours and 29 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 51 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: bcce1e82-59c9-4b9e-90f7-730d8af54696
📥 Commits

Reviewing files that changed from the base of the PR and between 56b4f0d and 02493e1.

📒 Files selected for processing: 12
  • .dockerignore
  • .github/dependabot.yml
  • CHANGELOG.md
  • docs/product_strategy-tr.md
  • docs/product_strategy.md
  • docs/roadmap/completed-phases.md
  • docs/roadmap/risks-and-decisions.md
  • docs/usermanuals/en/reference/yaml-templates.md
  • docs/usermanuals/tr/reference/yaml-templates.md
  • requirements-eval.txt
  • requirements-linux.txt
  • requirements.txt
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Reviewer's Guide

This documentation and housekeeping PR removes three stale dependency manifests, then aligns English and Turkish strategy, roadmap, and template-reference content with the implemented CLI/configuration behavior, current EU AI Act timing, and the medical template’s actual safety limitations; corresponding Unreleased changelog entries are included.

Flow diagram for documented safety evaluation paths

flowchart LR
    Model[Fine-tuned model]
    Chat[forgelm chat]
    SafetyEval[forgelm safety-eval]
    Training[Training or evaluation]
    Config[evaluation.safety]
    Model --> Chat
    Chat -->|No safety screening or YAML config| Exposed[Model exposed]
    Model --> SafetyEval
    SafetyEval -->|default probes| Screened[Screened model]
    Training --> Config
    Config -->|Safety evaluation before exposure| Screened
Loading

File-Level Changes

Change Details Files
Remove obsolete dependency manifests and clean up related Dependabot commentary.
  • Delete the three unused requirements files.
  • Remove the Dependabot note describing their pending cleanup.
  • Record the removal and migration to pyproject.toml extras in the unreleased changelog.
requirements.txt
requirements-eval.txt
requirements-linux.txt
.github/dependabot.yml
CHANGELOG.md
Correct roadmap and product-strategy claims to match current CLI behavior, configuration, and EU AI Act timing.
  • Document that forgelm chat performs no safety screening and reads no YAML configuration.
  • Replace the obsolete auto-revert field name with evaluation.auto_revert in both language versions.
  • Clarify staggered EU AI Act application dates and qualify the historical completed-phase wording.
  • Update live risk and opportunity rows to use Chapter III scope and current dates.
  • Document the roadmap corrections in the changelog.
docs/product_strategy.md
docs/product_strategy-tr.md
docs/roadmap/completed-phases.md
docs/roadmap/risks-and-decisions.md
CHANGELOG.md
Correct the medical-qa-tr template reference so its safety and compliance limitations are explicit.
  • State in the English and Turkish references that the template does not enable safety evaluation or include risk_assessment metadata.
  • Clarify that it is not intended for clinical decision support and prescribe accurate safety and risk-assessment configuration before non-demo use.
  • Record the correction in the changelog.
docs/usermanuals/en/reference/yaml-templates.md
docs/usermanuals/tr/reference/yaml-templates.md
CHANGELOG.md

Assessment against linked issues

Issue Objective Addressed Explanation
#968 Delete the three unreferenced requirements files and document how their lack of references was confirmed. ❌ The PR deletes all three files and says nothing referenced them, but it does not record how that was confirmed, as the acceptance criteria require.
#968 Reconcile the requirements.lock comment in pyproject.toml and the requirements.lock decision row in docs/roadmap/risks-and-decisions.md with the removal. ❌ The shown changes do not update the pyproject.toml comment or the requirements.lock decision row.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the unreferenced, stale requirements*.txt files (Dependabot will keep bumping them)

1 participant