Repository navigation
Conversation
Three requirements files sat at the repository root and nothing used them: the Dockerfile, the workflows, the tests and the documentation all install through the pyproject.toml extras. Their floors were far below pyproject's (torch>=2.0.0 against >=2.4.0, transformers>=4.38.0 against >=5.3.0), and Dependabot, which scans requirements*.txt, would have opened weekly pull requests against them from its first run. Also removes the note in .github/dependabot.yml that said they should be deleted when this cleanup landed, and the requirements*.txt line in .dockerignore, which no longer matches anything. The requirements.lock comment in pyproject.toml and its decision row in docs/roadmap/risks-and-decisions.md are about a future lock file, not these three, and stay as they are. Fixes #968 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves three unreferenced requirements manifests, along with stale Dependabot and Docker ignore references, and records the cleanup under the unreleased changelog; dependency installation continues to use pyproject.toml extras. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: removal of the stale requirements files. |
| Description check | |
The description is mostly complete. It includes the summary, linked issue, changes, type, testing result, checklist items, cleanup rationale, and confirmation that the files were unreferenced. |
| Linked Issues check | |
Issue #968 requires deletion of the three stale files or regeneration of any load-bearing file. The PR deletes requirements.txt, requirements-eval.txt, and requirements-linux.txt. The PR records… |
| Out of Scope Changes check | |
The changes stay within issue #968. The .github/dependabot.yml note and .dockerignore pattern are stale references to the deleted files. The CHANGELOG.md entry documents the requested removal. N… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
Full details: Linked Issues check
-
Explanation
Issue
#968requires deletion of the three stale files or regeneration of any load-bearing file. The PR deletesrequirements.txt,requirements-eval.txt, andrequirements-linux.txt. The PR records repository-wide checks that confirmed each file was unreferenced. Thepyproject.tomlcomment and roadmap decision row remain accurate because they describe a futurerequirements.lockworkflow, not the deleted files. The existingpyproject.tomldependencies and extras cover the deleted dependency entries.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue
#968. The.github/dependabot.ymlnote and.dockerignorepattern are stale references to the deleted files. TheCHANGELOG.mdentry documents the requested removal. No unrelated implementation or dependency behavior change is shown.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Merged
4 tasks done
Collaborator
Author
|
Superseded by #996: the wave-0 fixes are combined by theme into five pull requests to cut the review load. This branch's commits are included there unchanged apart from the |
cemililik
added a commit
that referenced
this pull request
Oct 18, 2026
…medical template row (#996) ## Summary Three small, already-reviewed fixes combined into one pull request, replacing #979, #980 and #981 (which will be closed as superseded). Each was green on its own and the bot findings on #980 and #981 are already folded in. ## Related issues Fixes #968. Refs #91, #75, #97. ## Changes | Was | What it does | |---|---| | #979 | Deletes the stale `requirements.txt`, `requirements-eval.txt` and `requirements-linux.txt`. Nothing referenced them, their floors were far below `pyproject.toml`'s, and Dependabot would have opened weekly PRs against them. Merging this **before Monday 2026-10-19** avoids those PRs. | | #980 | Roadmap/strategy corrections: `forgelm chat` does not screen for safety and reads no YAML (#91); live risk rows no longer name a past "August 2026" deadline and now limit the dates to Chapter III Sections 1–3 as CodeRabbit asked (#75); `docs/product_strategy.md` (EN+TR) names the real `evaluation.auto_revert` field. | | #981 | The `medical-qa-tr` row of the YAML templates reference (EN+TR): the template enables no safety evaluation and has no `risk_assessment` metadata; it is not for clinical decision support, and the row says to set `evaluation.safety.enabled: true` and fill in `risk_assessment` accurately (Sourcery and CodeRabbit findings applied). | ## Type - [x] Documentation - [x] Chore ## Testing - The full `CLAUDE.md` gauntlet from a clean worktree of this branch: exit 0. ## Checklist - [x] English and Turkish mirrors updated together - [x] CHANGELOG entries under `[Unreleased]` 🤖 Generated with [Claude Code](https://claude.com/claude-code) ## Summary by Sourcery Remove stale dependency files and correct safety, compliance, and medical-template documentation across the project. Bug Fixes: - Correct roadmap, risk, and strategy documentation to accurately describe chat safety behavior, EU AI Act timelines, and the current evaluation auto-revert configuration. - Clarify the medical QA template’s safety limitations and required evaluation and risk-assessment settings in English and Turkish references. Enhancements: - Remove the obsolete requirements files and direct installation guidance through pyproject.toml extras. Documentation: - Update the English and Turkish documentation mirrors and record the housekeeping and documentation corrections in the unreleased changelog. --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the three stale
requirements*.txtfiles and the two places that referred to them. Dependabot's first scheduled run is Monday 2026-10-19, and itspipecosystem scansrequirements*.txt, so these files would have received weekly pull requests.Related issues
Fixes #968
Changes
requirements.txt,requirements-eval.txt,requirements-linux.txt..github/dependabot.yml— drop the note that asked for these files to be removed "when the tracked cleanup lands"..dockerignore— drop therequirements*.txtline, which no longer matches anything.CHANGELOG.md— a### Removedentry.How each file was confirmed unreferenced: no match in
Dockerfile,docker-compose.yaml,MANIFEST.in,pyproject.toml, any workflow,tests/,tools/,forgelm/(code),notebooks/,site/or the documentation (README, CONTRIBUTING, the guides, reference, user manual, standards, QMS, design and roadmap pages). The only other hits are the CHANGELOG entry itself and a generic example inside a bundled chat template's training data (forgelm/templates/code-assistant/data.jsonl).Left alone on purpose: the
requirements.lockcomment at the top ofpyproject.tomland its decision row indocs/roadmap/risks-and-decisions.md(F-PR29-A6-lock-file). They are about a future lock file, not these three, and stay accurate.This takes the issue off the
good first issuelist, which then has 15 open issues.Type
Testing
CLAUDE.mdgauntlet from a clean worktree of this branch: exit 0.Checklist
[Unreleased]🤖 Generated with Claude Code
Summary by Sourcery
Remove stale requirements files to prevent unused dependency manifests from being maintained by Dependabot.
Enhancements:
Documentation:
Summary by CodeRabbit