fix: preserve Client sends after peer write EOF - #9
Merged
Merged
Conversation
Separate receive EOF from terminal transmit state so accepted output can still drain, while broken sends retain their cause and queued bytes. Reject later enqueue attempts and reset these facts only after allocating a new socket. This intentionally leaves local shutdown bookkeeping and all TLS behavior for follow-up PRs.
Collaborator
Author
|
Upstream dependency: this is the first Client-side directional-state change in #9–#17. It introduces This behavior must be adapted to the directional-state abstraction accepted on current upstream |
This was referenced Aug 28, 2026
Collaborator
Author
Collaborator
Author
|
Partially implements the Client portion of ioflo#172 by retaining terminal send causes and unsent bytes and rejecting later output after transmit closure. Connection-wide Client send errors in this PR still close only transmit, so the complete upstream contract remains open. #10 implements the corresponding Remoter behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Local receive EOF caused by peer write shutdown is directional and must not suppress Client transmission. Conversely, a terminal send failure must stop impossible retries without deleting accepted output or final peer input.
Boundary
This PR changes raw
Clientstate and enqueue behavior only. It does not change Remoter, TLS classification, connection-wide Client send classification, or graceful shutdown.