fix: retain TLS output and causes after send failure - #12
Merged
Merged
Conversation
Treat TLS WANT conditions as retryable, retain broken-pipe state without closing the receive direction, and force-close connection-wide SSL or socket failures. Every terminal path keeps the original cause and leaves unsent bytes queued. This PR does not start graceful TLS shutdown; recurrent close remains a follow-up concern.
Collaborator
Author
|
Upstream prerequisites: the directional state and unsent-output contract from #9/#10, followed by the truthful TLS wrapping and receive-outcome classification from #11. Only then can this send-side behavior classify WANT, broken pipe, fatal TLS, and connection-wide socket failures while retaining the original cause and unsent bytes. |
This was referenced Aug 28, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
A nonblocking retry is not a failure, a broken write does not necessarily end receive, and an unusable TLS transport must not remain represented as open. Conflating those outcomes either loses accepted output or permits impossible retries.
Boundary
This PR classifies established-session TLS send outcomes only. It does not initiate
close_notifyor implement recurrent graceful shutdown.