test: clarify TLS shutdown alias behavior - #17
Merged
kentbull merged 1 commit intoAug 27, 2026
Merged
Conversation
Rename the shutdown error test around the behavior it actually covers and document that both directional aliases enter the full TLS close_notify and unwrap path rather than performing raw socket half-closes.
Collaborator
Author
|
Upstream prerequisites: the TLS shutdown aliases from #14 and the corrected recurrent-shutdown oracle from #16. This PR only renames and documents a test proving that |
This was referenced Aug 28, 2026
Collaborator
Author
|
Adds the final downstream test clarification for ioflo#176: both |
kentbull
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename and document the shutdown error test around the behavior it actually covers:
shutdownSend()andshutdownReceive()both enter the TLSclose_notify/unwrap()path rather than performing raw TCP half-close.This PR changes tests only; production behavior is unchanged.