Skip to content

Goal: Close the landing-evidence certification gap in internal/loopdriver. `pr - #346

Closed
linhdmn wants to merge 1 commit into
mainfrom
devagent/TASK-mtxwr39q-nva6
Closed

linhdmn wants to merge 1 commit into
mainfrom
devagent/TASK-mtxwr39q-nva6

Conversation

@linhdmn

@linhdmn linhdmn commented Sep 12, 2026

Copy link
Copy Markdown
Member

Automated task via devagent task.

Prompt

Goal: Close the landing-evidence certification gap in internal/loopdriver. prState (issues.go:110) reads only state, so an iteration whose PR merged mid-run — loop 282: #345 merged 04:39:14Z inside its window, still recorded non-productive — has no evidence subject, since run.go:386's derivation requires OPEN before dispatch. Extend that one gh pr view to --json state,mergedAt behind a single prView helper (prState a thin wrapper; all five OPEN gates untouched). Pre-dispatch: retire a goal-head Land PR #N whose mergedAt precedes iteration start. Post-run: any PR #N in the goal with mergedAt inside [start, now] sets landed/evidencePR → ok. Tests: fake gh emits mergedAt; pin loop-282's window → ok, an out-of-window PR (e.g. #344) → unchanged, existing GH_PR_STATE_OPEN_CALLS pins green.

Repo policy: every PR keeps docs/PRD.md current — update the sections this change affects (status claims, architecture notes, roadmap/completion notes) and bump the Last updated footer in the same PR. A PR that changes repo state without reflecting it in docs/PRD.md is incomplete.

PRD state update (repo policy)

  • docs/PRD.md sections touched by this change are updated to the post-PR state
  • the Last updated footer reflects this change

@linhdmn

linhdmn commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

DevAgent zombie-PR sweep: auto-closing this PR.
Base branch main was merged or deleted, so this branch can no longer integrate.
Reopen with a re-targeted base if the work is still needed.

@linhdmn linhdmn closed this Sep 12, 2026
linhdmn added a commit that referenced this pull request Sep 12, 2026
The zombie sweep was still armed when these two pull requests were opened, and
its BaseBranchGone(main) transport-noise bug auto-closed both within minutes —
PR #347 and PR #346 themselves. Both heads already contained origin/main and
carried green evidence, so they land directly instead of through reopened pull
requests, with no re-implementation:

  1f2ef8c  devagent/TASK-mtxyflr1-fq6y  — three-valued pr-hygiene probes plus
                                          an auto-close age floor
                                          (internal/orchestrator, internal/cli)
  635214d  devagent/TASK-mtxwr39q-nva6  — landing-certification merge window
                                          (internal/loopdriver)

Only docs/PRD.* overlapped: the footer stamps are unioned and the direct
landing is recorded as a new stamp. docs/PRD.html regenerated with the
documented pandoc recipe.

Verified on the merged tree: go test ./... green, including
TestAutoMergeTreatsBaseProbeNoiseAsAlive and TestGhNotFoundOnlyForRealGone;
both heads are ancestors of main. Neither pull request was reopened or closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant