Repository navigation
Conversation
Member
Author
|
DevAgent zombie-PR sweep: auto-closing this PR. |
linhdmn
added a commit
that referenced
this pull request
Sep 12, 2026
The zombie sweep was still armed when these two pull requests were opened, and its BaseBranchGone(main) transport-noise bug auto-closed both within minutes — PR #347 and PR #346 themselves. Both heads already contained origin/main and carried green evidence, so they land directly instead of through reopened pull requests, with no re-implementation: 1f2ef8c devagent/TASK-mtxyflr1-fq6y — three-valued pr-hygiene probes plus an auto-close age floor (internal/orchestrator, internal/cli) 635214d devagent/TASK-mtxwr39q-nva6 — landing-certification merge window (internal/loopdriver) Only docs/PRD.* overlapped: the footer stamps are unioned and the direct landing is recorded as a new stamp. docs/PRD.html regenerated with the documented pandoc recipe. Verified on the merged tree: go test ./... green, including TestAutoMergeTreatsBaseProbeNoiseAsAlive and TestGhNotFoundOnlyForRealGone; both heads are ancestors of main. Neither pull request was reopened or closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated task via
devagent task.Prompt
Goal: Make both zombie-PR hygiene probes three-valued so transport noise can never close a live PR.
BaseBranchGone(internal/orchestrator/autopr.go:573) returns gone on any error — it closed fresh PR #346 76s after creation.landingCommitOnMain(pr-hygiene.go:102) returns "" on a failed read, which the triage (pr-hygiene.go:304-328) closes as "not shipped". Prove gone only on a definitive HTTP 404 (gh api -istatus line or stderr 404, neverGhError.Code— that is the gh exit code); prove alive on a 200 with no citing commit; skip, never close, on indeterminate, with an age floor before any close. Cover 404/200-no-match/200-match/timeout via fakeRunGhin pr-hygiene_test.go.Repo policy: every PR keeps docs/PRD.md current — update the sections this change affects (status claims, architecture notes, roadmap/completion notes) and bump the Last updated footer in the same PR. A PR that changes repo state without reflecting it in docs/PRD.md is incomplete.
PRD state update (repo policy)