Skip to content

Fix Forge conversion, offline-copy, and panel Escape regressions - #9

Merged
Enksodsoon merged 4 commits into
mainfrom
codex/forge-import-viewer-sync
Oct 15, 2026
Merged

Enksodsoon merged 4 commits into
mainfrom
codex/forge-import-viewer-sync

Conversation

@Enksodsoon

@Enksodsoon Enksodsoon commented Aug 13, 2026 •

Copy link
Copy Markdown
Owner

Changes

The original import and Viewer-sync implementation on this branch is already present on current main. This PR carries the verified fixes found while auditing the merged changes:

  • Let Escape cancel a saved-conversion rename without closing the History panel, and make the direct-OME test wait for and open the Review workflow step before checking its result.
  • Mark a cached Viewer offline copy unavailable when the remote content revision, known size, or SHA changes, while retaining the existing file on disk.
  • Reject offline-copy size reservations that overflow before downloading the response body.

Verification

  • Frontend: full Vitest suite and production TypeScript/Vite build with bundle budget.
  • Browser: Chromium import, direct OME result, Viewer library, responsive panel, teaching landmark, and viewer-budget checks with synthetic fixtures; desktop and narrow screenshots inspected.
  • Desktop: tests and syntax check.
  • Java 17: full tests and build, including focused recovery regressions.
  • Repository policy check.

Fresh GitHub Actions and independent review for this exact PR head are pending.

…ewer-sync

# Conflicts:
#	frontend/src/App.tsx
#	frontend/src/api.ts
#	frontend/src/styles.css
#	frontend/src/test/App.test.tsx
#	frontend/src/test/api.test.ts
#	src/main/java/org/pathlab/forge/server/ForgeServer.java
#	src/main/java/org/pathlab/forge/viewer/SqliteViewerSyncStore.java
#	src/main/java/org/pathlab/forge/viewer/ViewerSyncService.java
@Enksodsoon Enksodsoon changed the title Improve Forge import and Viewer sync UX Fix Forge conversion, offline-copy, and panel Escape regressions Oct 15, 2026
@Enksodsoon
Enksodsoon marked this pull request as ready for review October 15, 2026 05:11
@Enksodsoon
Enksodsoon merged commit 8b48961 into main Oct 15, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant