Repository navigation
fix(db): PoolSuite no longer races the driver's refusal (#320) - #347
Open
matteobovetti wants to merge 2 commits into
Open
matteobovetti wants to merge 2 commits into
matteobovetti wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The test "with the database down, the first read waits the acquire timeout" asserted that the
message contained the driver's word
refused. That holds only if the driver's connect has alreadyfailed when the 500 ms acquire timeout fires. Under load it had not, and the pool correctly said
"none recorded yet".
How
own words, and that neither the password nor
detachedleaks into the message.refused. It borrows until the pool has the driver's failure on record, witha 10 s deadline, so a real regression still fails with the last message.
bin/gateno longer lists PoolSuite as timing sensitive.Testcontainers 1.21.4
Docker Engine 29 answers testcontainers 1.21.3 with an empty 400, so no suite that starts Postgres
could run. Bumped to 1.21.4 in
project/Dependencies.scala. The examples build kept its ownliteral 1.21.3 and stayed red, so blog and shop now take
Dependencies.testcontainersPgthroughthe examples meta build, and the version has one home.
Not in this PR
ConnectionUnavailableSuitehas the same race at a 250 ms timeout. Left for a follow up.Closes #320